fix: Fix HLS live stream subtitle offsets #4586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subtitle timing and offsets were not calculated correctly for HLS live streams. This issue appears to have affected all v4.x releases up to v4.0.5, v4.1.5, and v4.2.2.
joeyparrish
added
type: bug
|
Incremental code coverage: 100.00% |
theodab
approved these changes
Oct 18, 2022
joeyparrish
added a commit
that referenced
this pull request
Oct 18, 2022
Subtitle timing and offsets were not calculated correctly for HLS live streams. This issue appears to have affected all v4.x releases up to v4.0.5, v4.1.5, and v4.2.2.
joeyparrish
added a commit
that referenced
this pull request
Oct 18, 2022
Subtitle timing and offsets were not calculated correctly for HLS live streams. This issue appears to have affected all v4.x releases up to v4.0.5, v4.1.5, and v4.2.2.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtitle timing and offsets were not calculated correctly for HLS live streams. This issue appears to have affected all v4.x releases up to v4.0.5, v4.1.5, and v4.2.2.