fix(preload): Fix preload load latency logic. #6890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when preloading, we would measure startTimeOfLoad based on when the PreloadManager was created. This meant that if a PreloadManager was created and then not used for a while, it would lead to the load latency stats reporting an extreme load latency. This changes the startTimeOfLoad to instead record when the PreloadManager is consumed by the player. Fixes shaka-project#6871
avelad
approved these changes
Jun 24, 2024
|
Incremental code coverage: 100.00% |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when preloading, we would measure startTimeOfLoad based on when the PreloadManager was created.
This meant that if a PreloadManager was created and then not used for a while, it would lead to the load latency stats reporting an extreme load latency.
This changes the startTimeOfLoad to instead record when the PreloadManager is consumed by the player.
Fixes #6871