Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End-to-end tests fail when run from another directory #49

Closed
joeyparrish opened this issue Jan 31, 2020 · 0 comments · Fixed by #71
Closed

End-to-end tests fail when run from another directory #49

joeyparrish opened this issue Jan 31, 2020 · 0 comments · Fixed by #71
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v1.0

Comments

@joeyparrish
Copy link
Member

It's not clear why, but the end-to-end tests seem to fail when run from a directory other than the project root. This is in spite of the test runner changing directories to the project root almost as soon as it starts.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jan 31, 2020
@shaka-bot shaka-bot added this to the v1.0 milestone Jan 31, 2020
@mariocynicys mariocynicys mentioned this issue Apr 6, 2021
Merged
joeyparrish pushed a commit that referenced this issue Apr 12, 2021
@mariocynicys
fix: Fix tests running from any directory (#71)
10c8f46 
Now the tests can be run from any directory, not just from the root of the repo.

Fixes #49
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 11, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

now tests are runnable from any directory
2 participants
@joeyparrish @shaka-bot