Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

now tests are runnable from any directory #71

Merged
merged 1 commit into from
Apr 12, 2021
Merged

now tests are runnable from any directory #71

merged 1 commit into from
Apr 12, 2021

Conversation

mariocynicys
Copy link
Contributor

fixes #49

@google-cla
Copy link

google-cla bot commented Apr 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mariocynicys
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll run the tests and merge if everything is passing.

@joeyparrish joeyparrish merged commit 10c8f46 into shaka-project:master Apr 12, 2021
@joeyparrish
Copy link
Member

Tests are passing from any directory. Thanks so much for your fix!

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End-to-end tests fail when run from another directory
2 participants