Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont Upload If GIST and settings content are the same. #316

Closed
shanalikhan opened this issue May 8, 2017 · 1 comment
Closed

Dont Upload If GIST and settings content are the same. #316

shanalikhan opened this issue May 8, 2017 · 1 comment
Labels
feature-request 💡 fixed
Milestone
v3.4.0

Comments

@shanalikhan
Copy link
Owner

When user hit upload.
Extension needs to check either the settings content are updated compared to existing GIST.

  1. If yes then upload
  2. If no, it should not upload the settings again.

forceUpload can provided to user like forceDownload in order to forcefully hit upload in Gist.

Original suggestion from @borekb on #232 (comment)
@shanalikhan shanalikhan modified the milestones: v3.0, v2.9 May 8, 2017
@shanalikhan shanalikhan self-assigned this Jun 14, 2017
@shanalikhan shanalikhan mentioned this issue Jul 5, 2017
Closed
@shanalikhan shanalikhan modified the milestones: v2.9, Backlog Feb 4, 2018
@shanalikhan shanalikhan modified the milestones: Backlog, v3.1 Feb 25, 2018
@shanalikhan shanalikhan modified the milestones: v3.1, Backlog Jul 14, 2018
@shanalikhan
Copy link
Owner Author

@arnohovhannisyan and this one

@auxves auxves mentioned this issue Jun 25, 2019
Merged
3 tasks
@shanalikhan shanalikhan modified the milestones: Backlog, v3.4.0 Jun 25, 2019
shanalikhan pushed a commit that referenced this issue Jun 25, 2019
@auxves @shanalikhan
#350 #316
e1552d0 
* Rename package.nls.pt.json to package.nls.pt-br.json

This aligns the filename to the one needed by VSCode.

* Fix issues on first install

* Safe Upload

* Add option in Other Options menu and update Readme

* Fix requested changes

package.nls.*.json
----
Reorder keys to be alphabetical

sync.ts
----
Notify that the upload was cancelled

github.service.ts
----
Update function name to IsGistNewer
@shanalikhan shanalikhan mentioned this issue Jul 9, 2019
Closed
@shanalikhan shanalikhan removed their assignment Jul 16, 2019
@karl-lunarg karl-lunarg mentioned this issue Aug 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request 💡 fixed
Projects
None yet
Milestone
v3.4.0
Development

No branches or pull requests
1 participant
@shanalikhan