-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safe Upload #923
Safe Upload #923
Conversation
This aligns the filename to the one needed by VSCode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is v3.4.0 worthy. Base branch updated.
package.nls.*.json ---- Reorder keys to be alphabetical sync.ts ---- Notify that the upload was cancelled github.service.ts ---- Update function name to IsGistNewer
Can you try with other scenario by pushing from one computer and then pushing from second computer ( without pulling ) , It should not upload as first computer has pushed the most updated settings. |
@shanalikhan I have just tested that and it works. |
Gist LINK : https://gist.github.com/shanalikhan/e86911443d3f81be6a66699603aee6dc It should not ask to force upload because lastUpload is Null and in cloudSettings settings date is old. |
@shanalikhan This will be fixed in #937. |
Can you fix it in |
Ubuntu, Standard Latest Code version. Build package and installed that package and test results For #316 Second, autoUpload doesnt seems to working at my end. Can you test autoUpload scenarios at your end by testing on package and install locally. |
Any update on this ? So the PR you have send will not allow user to upload the settings second time if there is not any difference between first upload content ? |
If there is no difference between remote and local settings, a message box will be shown to the user informing them about it and giving them the option to enable |
Short description of what this resolves:
This PR enables "safe" upload functionality.
Changes proposed in this pull request:
forceUpload
Fixes: #350 #316
How Has This Been Tested?
Tested by uploading to gist with contents older or identical to the gist.
Checklist: