Add webpack bundling for faster startup

[thejewdude]

Short description of what this resolves:

This PR improves extension startup time by bundling with webpack. On my local environment startup is down to 400 - 500 ms in the "Running Extensions" view.
I would love to be able to compare Javascript profiles of before and after but I don't know how to profile extension startup time in vscode.

Changes proposed in this pull request:

Fixes: #656

How Has This Been Tested?

I was able to build the extension using the npm scripts including compile, watch, and vscode:prepublish. I tested the changes on my environment and was able to download my settings stored in github gist.

My environment: windows 10; vscode 1.29.1 (user setup)

Screenshots (if appropriate):

Checklist:

• I have read the contribution guidelines.
• My change requires a change to the documentation and Github Wiki.
• I have updated the documentation and Wiki accordingly.

[thejewdude]

Tests seem to be broken; I'm getting this error
Error: Cannot find module 'C:\Users\theje\source\repos\code-settings-sync\node_modules\bin\mocha'

[shanalikhan]

I would love to be able to compare Javascript profiles of before and after but I don't know how to profile extension startup time in vscode.

Can you compare current version before and after your PR and post the image.

"Startup Up Performance"

and Running Extensions

[thejewdude]

Sure thing, will get to this after work

[thejewdude]

Before:

After:

[shanalikhan]

Can you fix the tests also?

[thejewdude]

I was able to get the tests running again but a bunch of tests are failing now. 1 failure is because of how windows handles newlines (CRLF vs LF); and 1 failure because of the difference between windows directory seperators.
Were all the passing up until now?

[thejewdude]

I actually checked out to your current master and the test (I ran npm run test) script seems to be broken. It looks like this part of the test script is causing the problem: node ./node_modules/bin/mocha. I checked the node_modules folder and the bin folder doesn't exist, at least not on my machine.

The error:

[thejewdude]

So it seems that the reason why the tests were failing on machine is because of line ending shenanigans and git. After turning off the git config core.autocrlf the tests pass. It might be worth adding an editorconfig file to configure LF line endings as the default for the repo.

Side note: It looks like the sync pragma feature will only work with a setting file that has LF line endings since the regexp that searches for pragmas uses the LF line ending. This is not really an issue since vscode creates the settings files with LF line endings by default.

@shanalikhan is there anything else I should to do in order to get this merged?

[shanalikhan]

alright. That's perfect.

I will merge it in few days.

[shanalikhan]

Its not working at my side.
Can you create a package of extension by vsce package by pulling the branch v3.2.3

and then install it via code --install-extension
The Advance Setting menu appearing as:

[thejewdude]

Yes i'll check this out now

[thejewdude]

The webpack dependencies are missing in package.json. It might have gotten lost when my branch was merged in, since other changes were made to the same part of package.json.
Should I rebase and open a new PR?

[shanalikhan]

The webpack dependencies are missing in package.json

Yes, ts-loader was found missing, i build after filling all dependencies in my local and got into the problem i shown in previous comment.
Since you are working, yes send PR at once after by creating vsce package and testing by installing on your local machine ( instead of testing by building)

[thejewdude]

Ok I can do it later today

[thejewdude]

Sorry for the delay. I wasn't able to package the extension because I was running into npm errors . Now that I sorted that out I ran into the same issue you posted. I will investigate tonight.