Fix loading language bundles and add missing dependencies #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanalikhan
added a commit
that referenced
this pull request
Dec 13, 2018
…)" This reverts commit 7e5175f.
shanalikhan
added a commit
that referenced
this pull request
Dec 13, 2018
* add support for Coder.com (#714) Checks for extension `coder.coder` to tell if the IDE is Coder + VS Code or just a regular VS Code installation. * add webpack bundling for faster startup * use tsc to compile tests * make tests run * v3.2.3 release * v3.2.4 * Always use VSCODE_PORTABLE env when portable Mac will no longer use Application Support while in portable mode * Token error on HTTP 401 - Display token error on 401, as the current method was displaying generic error for me. Also opens GitHub tokens page on error > Doesn’t listen for 403 errors as this shouldn’t ever happen with current setup, but we could add later - Use error.status instead of error.code to avoid depreciation logging * Fix loading language bundles and add missing dependencies (#736) * add webpack bundling for faster startup * use tsc to compile tests * make tests run * rebase on v3.2.3 * fix loading language bundles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #717 I fixed the issue with the commands not being correctly translated. It looks like the root path of the extension wasn't being set correctly.
I packaged the extension with
vsce packageand installed it on my machine withcode --install-extension. The Advanced Settings menu is now appearing correctly.