Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Button to Download Public Gist #941

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Add Button to Download Public Gist #941

merged 2 commits into from
Jul 2, 2019

Conversation

auxves
Copy link
Contributor

@auxves auxves commented Jul 2, 2019

Short description of what this resolves:

This PR adds a button to the landing page to download public gist.

Changes proposed in this pull request:

  • Add button to landing page
  • Ask for gist id when clicked, and save it
  • Enable downloadPublicGist

Fixes: #876 (comment)

Checklist:

@shanalikhan
Copy link
Owner

  1. We need to run the Download Process also
  2. We need to empty the current GIST, input box should prompted like old way to allow user to add GIST and hit enter to download. ( if we can use UI for this purpose only, your suggestion on this ? )

See this :
https://github.com/shanalikhan/code-settings-sync/blob/master/src/sync.ts#L979
https://github.com/shanalikhan/code-settings-sync/blob/master/src/sync.ts#L819

@shanalikhan shanalikhan added this to the v3.4.0 milestone Jul 2, 2019
@auxves
Copy link
Contributor Author

auxves commented Jul 2, 2019

@shanalikhan

We need to empty the current GIST, input box should be prompted like the old way to allow the user to add GIST and hit enter to download.

This is already part of the PR. When the link is clicked, an input box is shown where the user can input the gist id. When they hit enter, it will save that gist id to the extension config and download.

if we can use UI for this purpose only, your suggestion on this?

I think it would be much easier to just use the input box as it's much quicker than informing the user how to do it in the Settings UI.

@shanalikhan shanalikhan merged commit 632b6ae into shanalikhan:v3.4.0 Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants