-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 0 is falsey 🤦♂️ #4177
fix: 0 is falsey 🤦♂️ #4177
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See review from shapeshift/lib#1230, pre-stamp, will stamp this as soon as the lib PR gets in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sanity retested this after bumping the swapper dep, confirmed I wasn't able to see negative amounts for CoW (and miner fees are properly displayed for ZRX/Thor)
Description
Fixes a bug where
hasNegativeRatio
would be false ifinputOutputRatio
was0
.Relates to a
lib
fix: shapeshift/lib#1230, however it's not a dependancy and this PR can go in without it.Notice
Pull Request Type
Issue (if applicable)
N/A
Risk
Very small.
Testing
Couple with an incoming
lib
PR. TODO.Engineering
Operations
Screenshots (if applicable)
N/A