fix: minimum amounts #4178
Merged
fix: minimum amounts #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Apr 3, 2023
Merged
gomesalexandre
previously approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Tested locally:
Less than minimum amount
Amount greater than the minimum amount
Looks good to me as far as the preview button flow goes, though the swapper selection still shows "Insufficient sell amount". Given that one is currently still flagged off on prod, this isn't a blocker but we should make sure to reflect the same minimum in the swapper selection UI before we turn the flag on
gomesalexandre
force-pushed
the
04-03-fix_minimum_amounts
branch
from
97bcd15
to
38a0675
Compare
gomesalexandre
force-pushed
the
04-03-fix_minimum_amounts
branch
from
38a0675
to
3dc2299
Compare
gomesalexandre
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We deprecated
minimumin favour ofminimumCryptoHumanat some point, but never updatedwebto match.This is causing minimum amount issues for quotes in the swapper.
This PR fixes updates all instances of
minimumtominimumCryptoHuman, fixing the minimum amount issues we are having (particularly for CoW Swap).Notice
Pull Request Type
Issue (if applicable)
N/A - prod bug
Risk
Small.
Testing
Enter a small amount for a CoW swap quote and see that it now correctly prevents the user from proceeding.
Engineering
☝️
Operations
☝️
Screenshots (if applicable)