forked from prebid/Prebid.js
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from prebid:master #1601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Discovery Bid Adapter : add title, desc, keywords, hLen, nbw, hc, dm add unit test resolve conflict * Discovery Bid Adapter : add title, desc, keywords, hLen, nbw, hc, dm add unit test * Discovery Bid Adapter : synchronize mguid from third party cookie to first party cookie * test * Discovery Bid Adapter : Extend the expiration time of pmguid * Discovery Bid Adapter : Extend the expiration time of pmguid * Discovery Bid Adapter : Extend the expiration time of pmguid * Discovery Bid Adapter : Extend the expiration time of pmguid --------- Co-authored-by: lvhuixin <lvhuixin@baidu.com>
Co-authored-by: Gabriel Chicoye <gabriel@macbookrogab24g.lan>
…1173) * Update tests for sspBC adapter Update tests for sspBC adapter: - change userSync test (due to tcf param appended in v4.6) - add tests for onBidWon and onTimeout * [sspbc-adapter] 5.3 updates: content-type for notifications * [sspbc-adapter] pass CTA to native bid * [sspbc-5.3] keep pbsize for detected adunits * [maintenance] - remove old test for sspBc bid adaptor * [sspbc-5.3] increment adaptor ver * [sspbc-adapter] maintenance update to sspBCBidAdapter * remove yarn.lock * Delete package-lock.json * remove package-lock.jsonfrom pull request * [sspbc-adapter] send pageViewId in request * [sspbc-adapter] update pageViewId test * [sspbc-adapter] add viewabiility tracker to native ads * [sspbc-adapter] add support for bid.admNative property * [sspbc-adapter] ensure that placement id length is always 3 (improves matching response to request) * [sspbc-adapter] read publisher id and custom ad label, then send them to banner creative * [sspbc-adapter] adlabel and pubid are set as empty strings, if not present in bid response * [sspbc-adapter] jstracker data fix * [sspbc-adapter] jstracker data fix * [sspbc-adapter] send tagid in notifications * [sspbc-adapter] add gvlid to spec; prepare getUserSyncs for iframe + image sync * update remote repo * cleanup of grupawp/prebid master branch * update sspBC adapter to v 5.9 * update tests for sspBC bid adapter * [sspbc-adapter] add support for topicsFPD module * [sspbc-adapter] change topic segment ids to int * [sspbc-adapter] update v5.93 - add suport for DSA and non-standard user id's * [sspbc-adapter] update v5.93 - remove unnecessary gdpr data * [sspbc-adapter] remove debug * [sspbc-adapter] fix tests --------- Co-authored-by: Wojciech Biały <wb@WojciechBialy.local>
* New bidder adapter: Publir * Added hello world for test * Verified test cases * Changes made as per the feedback. * updated code as per the feedback. * Updated impression url. * Update Impression call * Added more test cases for increasing Coverage * updated test cases * Added condition as per the feedback * updated fix * Added conditions
* Pstudio initial bidder * remove unnecessary return * Use Storage and Floor Module * mend * use proper url for adapter * Update modules/pstudioBidAdapter.js Co-authored-by: Olivier <osazos@adagio.io> --------- Co-authored-by: Noemi Kowalewska <ccwa-491@noemi-kowalewska.local> Co-authored-by: Olivier <osazos@adagio.io>
Co-authored-by: federico <f.liccione@onetag.com>
…11197) * Logging price bucket value for the bid * Converting data type for logging * Dummy Commit --------- Co-authored-by: pm-azhar-mulla <azhar@L1119.local>
Co-authored-by: vrishko <vasyl.rishko@smartyads.com>
* fix: added fix for automatadAnalytics * fix: add s3 upload for atmtd * fix: add upload to s3 * fix: removed changes to gulp file and package.json * fix: added build command to gulp * fix: removed extra line from gulpfile * restored original gulp file * fix: minor fix to condition * fix: removed unnecessary condition * fix: removed linting error * Get build check to re run --------- Co-authored-by: Shashank <=>
* cookie-look-up-logic-fix-gpp-fix * refactor using ORTB conversion library --------- Co-authored-by: ahmadlob <109217988+ahmadlob@users.noreply.github.com> Co-authored-by: Ahmad Lobany <ahmad.l@taboola.com> Co-authored-by: aleskanderl <109285067+aleskanderl@users.noreply.github.com>
* KargoBidAdapter: GPP Support * kargo adapter to forward schain object (#21) * wrap in if statement (#22) * KRKPD-572: Add spec for schain (#23) * wrap in if statement * update test for schain, file formatting * Adding site to Kargo adapter. * KRKPD-619 Updating Site object. * KRKPD-619 Adding null check for Site object. * Update modules/kargoBidAdapter.js Co-authored-by: Julian Gan <juliangan07@gmail.com> * Reducing the size of Site object. * remove white space that is causing linting error * Kargo Bid Adapter: Updates to gpid retrieval * Support for sending ortb2.user.data * update bid Response to use actual creativeID * update spec * fix nomencalature based on Kargo's service * Prebid.js - Update bid Response to use actual creativeID (#25) * update bid Response to use actual creativeID * update spec * fix nomencalature based on Kargo's service * utilize floors mod * fixes tests * mediatype specific floors * simpler implementation leveraging Prebid's smart rule selection * revert nomenclature change * fix * removes comment --------- Co-authored-by: Jeremy Sadwith <jeremy@kargo.com> Co-authored-by: Julian Gan <juliangan07@gmail.com> Co-authored-by: Neil Flynn <nflynn@kargo.com> Co-authored-by: “Nick <“nick.llerandi”@kargo.com> Co-authored-by: Nick Llerandi <nick.llerandi@kargo.com>
* add support for native in rasbidadapter * lint fixs * final logic fix * final logic fix * corner case fix * update rasBidAdapter.md
….2 (#11089) * add gdpr verification for user-centric modules * fix log messages * refactor logger * small refactors in code and import order * add new purpose ids and special feature 1 * remove special feature one, keep purposes 1, 3, 4, 5 and 7 * remove special feature one, keep purposes 1, 3, 4, 5 and 7 * remove special feature one, keep purposes 1, 3, 4, 5 and 6 * fix lint warning jsdoc/no-undefined-types * fix typos * update doc * fix link in doc
* Added dsa transparency * fix linting * fixed linting * Removed validation * removed unused var --------- Co-authored-by: Max Dupuis <118775839+maxime-dupuis@users.noreply.github.com>
* Pstudio initial bidder * remove unnecessary return * Use Storage and Floor Module * mend * use proper url for adapter * Update modules/pstudioBidAdapter.js Co-authored-by: Olivier <osazos@adagio.io> * Use production pstudio url --------- Co-authored-by: Noemi Kowalewska <ccwa-491@noemi-kowalewska.local> Co-authored-by: Olivier <osazos@adagio.io>
Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com> Co-authored-by: Alexey Surovenko <ASurovenko@vdhk6ddf9m.home>
* allow postInstall for the userId * Update index.js * Update index.js --------- Co-authored-by: Patrick McCann <pmccann@cafemedia.com>
* added support for gpp consent string * changed test for nextMillenniumBidAdapter * added some tests * added site.pagecat, site.content.cat and site.content.language to request * lint fix * formated code * formated code * formated code * pachage-lock with prebid * pachage-lock with prebid * formatted code * added device.sua, user.eids * formatted * fixed tests * fixed bug functio getSua * fixed bug imp.video.mimes * fixed bug imp.video.mimes - 2
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Removing validation for the value of video.protocol
… side (#11217) * Adapter does not seem capable of supporting advertiserDomains #6650 added response comment and some trivial code. * removed a blank line at the end of file added a space behind the // in comments * in response to comment from reviewer. add the aspect of advertiserdomain in unit tests * added the code to get the keywords from the meta tags if available. * WIP * cleaned up * correcting formatting errors from circleci * sending floor to our backend for each bid, when available, changed one of the 1st party cookies that we want to send to backend * fixed spacing issues in code * 1/ provide the possibility of using the jixie section of the config object to determine what ids to read from cookie and to send 2/ removed ontimeout handling 3/ bidwon just ping the trackingUrl, if any 4/ misc: sending aid (from jixie config if any), prebid version etc * corrected formatting mistakes * adding support of handling usersync array from the server side * add back registerBidder line dropped accidentally * fixed some formatting flaws * correcting more formatting issues * more formatting corrections
…1385) * Update consentManagementGpp.js * Update consentManagementGpp.js * Update consentManagementGpp.js * Update consentManagementGpp.js * Update modules/consentManagementGpp.js Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
…nt in the proper field (#11416)
Co-authored-by: pm-azhar-mulla <azhar@L1119.local>
* Enable supplyChain support * Added support for COPPA * rebuilt * Added support for Extended User IDs. * Added support for the "meta" attribute in bid response. * Delete nobidBidAdapter.js.orig * Delete a * Delete .jsdtscope * Delete org.eclipse.wst.jsdt.ui.superType.container * Delete org.eclipse.wst.jsdt.ui.superType.name * Delete .project * Renamed the Analytics Adapter to "nobid" otherwise it wouldn't work with the wrapper builder on the Prebid.js website and added Prebid version "pbver" to the bidding and analytics requests. --------- Co-authored-by: Reda Guermas <reda.guermas@nobid.io>
* KRKPD-1083: Refactor and expand testing (#31) * Refactor the Kargo adapter testing to be more comprehensive and include testing of invalid inputs * Fix the window size test to pull data from the browser instead of hardcoded values * Remove a duplicate test * unhook triggerPixel after tests * fixes circleci failure * Update the localStorage non-functional test In FireFox, having localStorage.getItem throw an error isn't working so the test was updated to not have a valid localStorage value to pass on FireFox. * Restore the bidderSettings following testing --------- Co-authored-by: William Klausmeyer <klawil@users.noreply.github.com> Co-authored-by: “Nick <“nick.llerandi”@kargo.com> Co-authored-by: William Klausmeyer <willyk95@gmail.com>
* Add pubx RTD module * Add pubx RTD module documentation * Add basic tests for pubx RTD module * Fix the failing tests * Added logic to fetch floors and set to auction * Updated setDataToConfig to attach floors data to bidder requests object * pubx rtd module: * fetch floor rules * timeout defaults * floors config customizations * pubx on/off from floors response * move fetch floors to init and also wait for it before auction * TESTS: update * replace createFloorsDataForAuction to avoid circular dep - WIP * reset default floors when no floor response is received * TESTS: add test * tag integration - fetch floors api events * * Remove coonsole.log * move __pubxFloorRulesPromise__ to window * Remove unused var error * TESTS: add getBidRequestData, refactor stubs * TESTS: setFloorsApiStatus * TESTS: add fetchFloorRules * remove useRtd * make endpoint potional and take pubxId form provider config * TESTS: use xhr to fakeServer instead of sinon * make default data optional * update README * TEST: update tests * add integration example * remove floorProvider from default config * fix linting * update readme.md --------- Co-authored-by: Phaneendra Hegde <phaneendra@pubx.ai> Co-authored-by: Phaneendra Hegde <pnhegde@users.noreply.github.com>
* Adding Lockr AIM module and tests * formatting * Fix formatting * format * fix formatting * add paapi back * added markdown file * 20240324 Fixed Storage Manager | lockrAIMIdSystem.js * Updated to use Prebid Storage Manager | lockrAIMIdSystem_shared.js * added the fix for the comments * removed the unnecessary console --------- Co-authored-by: chris-lockr <chris@loc.kr> Co-authored-by: avin-lockr <avin@loc.kr>
* removed currency from getFloor * removed currency from generateBidParameters * removed currency from optional params in md * removed currency from test --------- Co-authored-by: Dedi Sidi <dedi.sidi@risecodes.com>
* removed currency from getFloor * removed currency from generateBidParameters * removed currency from optional params in md * removed currency from test
* removed currency from getFloor * removed currency from generateBidParameters * removed currency from test * removed currency from optional params in md * removed currency
* removed currency test * removed currency from optional params in md * removed currency from generateBidParameters * removed currency from getFloor
Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10. - [Release notes](https://github.com/mde/ejs/releases) - [Commits](mde/ejs@v3.1.9...v3.1.10) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Antoine Niek <antoineniek@gmail.com>
* First commit * fix: readme.md * fix: changed exads urls * fix: Tools and suggestions related to the doc * fix: from code review * fix: from code review * fix: from code review * fix: error from code review - native example * fox: from code review * fix: from code review * fix: from code review * fix: native img set as mandatory * fix: from code review * fix: from code review * fix: from code review * fix: from code review * fix: from code review * fix: from code review * fix: bidfloor and bidfloorcur set as optional * fix: dsa * fix: mananing multiple responses * fix: unit test after code review * fix: fixing native snippet code * fix: from code review * fix: video events after code review * fix: video module into documentation * fix: impression tracker for native * fix: afeter code review * fix: unit tests * fix: added badv and bcat * fix: video -> mimes and protocols * fix * fix: removed image_output and video_output params, forcing always html for rtb banner * fix: gulp * fix: added site.name * fix: removed EXADS dir * fix: after linting * fix: unit tests * fix: final dsa solution * fix: dsa * fix: fix instream example * fix: doc media type context * fix: documented the endpoint param into native section * fix: related to markdown lint validation (#2) * fix: from CR (#3) --------- Co-authored-by: tfoliveira <tfoliveira@users.noreply.github.com>
* eight pod init * fix mocks * specify eightPodAnalyticAdapter tests * update Event import
Co-authored-by: johwier <john.wier@epsilon.com>
- Response handling will be done separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )