Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking Code Cleanup (v2.0) #41

Closed
tthiery opened this issue Jul 4, 2020 · 2 comments
Closed

Breaking Code Cleanup (v2.0) #41

tthiery opened this issue Jul 4, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone
v2.0

Comments

@tthiery
Copy link
Member

tthiery commented Jul 4, 2020

No description provided.

@tthiery tthiery added this to the v1.1 milestone Jul 4, 2020
@tthiery tthiery added the enhancement New feature or request label Jul 4, 2020
tthiery added a commit that referenced this issue Jul 8, 2020
@tthiery
Cleanup TODOs
2c702d6 
#41 non-breaking
@tthiery tthiery changed the title Non-Breaking Code Cleanup (v1.1) Breaking Code Cleanup (v2.0) Jul 10, 2020
@tthiery
Copy link
Member Author

tthiery commented Jul 10, 2020

no breaking code cleanup actually.

@tthiery tthiery closed this as completed Jul 10, 2020
tthiery added a commit that referenced this issue Aug 1, 2020
@tthiery
Switch HubFactory to use Transients
3a4f709 
- ActivatorUtilities is just creating an object instace
  while using Transients will keep the object in the DI
  container until the scope is discarded
- Externalize Hub Configuration from constructor

#41 non-breaking
@tthiery
Copy link
Member Author

tthiery commented Aug 1, 2020

wrongly aligned commit
=> #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
1 participant
@tthiery