Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup ServiceLocator pattern in favor of proper DI #46

Closed
7 tasks done
tthiery opened this issue Jul 8, 2020 · 1 comment
Closed
7 tasks done

Cleanup ServiceLocator pattern in favor of proper DI #46

tthiery opened this issue Jul 8, 2020 · 1 comment
Assignees
@tthiery
Labels
enhancement New feature or request
Milestone
v2.2

Comments

@tthiery
Copy link
Member

tthiery commented Jul 8, 2020 •
edited
Loading

  • Active Connection == own Scope
    • Create Scope in host during hub/protocol initialization
  • Move the following types to a AddScoped lifetime
    • BluetoothKernel (remove bluetoothAddress from constructor and move to ConnectAsync)
    • PoweredUpProtocol (add deviceFactory as a constructor argument and remove IServiceProvider service locator trap)
    • Rewrite DeviceFactory/HubFactory to use Transient types in the IServiceProvider. OPEN QUESTION: How to handle hubId and portId in an elegant way
    • Add constructor argument deviceFactory to hub.
  • Add interface to PoweredUpHost to wire up a protocol

non-breaking in theory
@tthiery tthiery added the enhancement New feature or request label Jul 8, 2020
@tthiery tthiery added this to the v2.2 milestone Aug 1, 2020
@tthiery tthiery self-assigned this Aug 1, 2020
tthiery added a commit that referenced this issue Aug 1, 2020
@tthiery
Change PoweredUpHost to initialize scope
0b0406e 
#46 non-breaking
tthiery added a commit that referenced this issue Aug 1, 2020
@tthiery
Remove ServiceProvider usage from Hub
46c1cb9 
- Add constructor for IDeviceFactory
- Moved PoweredUpProtocol creation into the DI + Host
- Moved BluetoothKernel creation into the DI

#46 non-breaking (all types internal)
@tthiery tthiery mentioned this issue Aug 1, 2020
Closed
@tthiery
Copy link
Member Author

tthiery commented Aug 1, 2020

Wrongly aligned commit 3a4f709

@tthiery tthiery mentioned this issue Aug 1, 2020
Merged
tthiery added a commit that referenced this issue Aug 1, 2020
@tthiery
Fix Unit Tests
a7a0028 
#46 non-breaking
tthiery added a commit that referenced this issue Aug 3, 2020
@tthiery
Change CLI to be based on DI
027fffa 
- Change CLI code base to user DI instead of SL pattern
- Remove Infrastructure code from CLI commands
- Add PoweredUpHost.CreateProtocol and expose
  related scoped service provider on IPoweredUpProtocol

#46 non-breaking (since non-host direct communication is not contract)
tthiery added a commit that referenced this issue Aug 3, 2020
@tthiery
Add some notes about the DI container
90ef45f 
#46 non-breaking
tthiery added a commit that referenced this issue Aug 4, 2020
@tthiery
Adjust CLI for better seperation of concern
cbac0cc 
#46 non-breaking
tthiery added a commit that referenced this issue Aug 6, 2020
@tthiery
Remove Service Locator from most sample code
f8fcc7d 
#46 non-breaking
tthiery added a commit that referenced this issue Aug 6, 2020
@tthiery
Update examples
6152659 
- Expose CreateProtocolScope method in host

#46 non-breaking
tthiery added a commit that referenced this issue Aug 6, 2020
@tthiery
Cleanup IServiceProvider (as service locator usage)
d93e386 
- Remove many Service Locator usages
- Move HubFactory to be based on DI
- Move Protocol creation into DI and out of hub etc.
- Adjust CLI
- Fix await warnings

#46 non-breaking (all types internal)
@tthiery tthiery closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tthiery tthiery

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
1 participant
@tthiery