Add Mario (from set 71360) #91
Comments
tthiery
added
enhancement
|
See related nathankellenicki/node-poweredup#103 |
|
Hi @tthiery ! |
|
Hi @judavi I am happy to give you the needed guidance! To onboard Mario,
I had a look at your code and I am not perfectly sure whether either your code is wrong (especially the switch instruction argument |
- This allows the CLI to actual work #91 non-breaking
- This allows the CLI to actual work #91 non-breaking
|
@judavi i have eliminated the first step to simplify your onboarding. You would need to pull the code, compile it with .NET Core 3.1 and run the CLI project with the arguments |
- Devices are empty shells currently #91 non-breaking
|
@judavi Got a bit excited and added already a pull request (#93). However, here I would need to stop. I would need the dump of the following commands (from the CLI project) to continue working without actual hardware ...
The rest I would need to do (blindly w/o testing) the following work documented here. |
|
dotnet run -- device list dotnet run -- device dump-static-port -p 0 |
|
dotnet run -- device dump-static-port -p 1 dotnet run -- device dump-static-port -p 2 dotnet run -- device dump-static-port -p 3 dotnet run -- device dump-static-port -p 6 |
|
Thanks. I will incorporate the stuff later today and write some scripts for testing. Awesome! |
|
Great!! thanks @tthiery !! It took me a while to find a computer with Windows at home 😅 |
|
Yeah, I guessed so. Seeing your repos and language choices. Btw, I have not heard of a go library for powered up devices. It is a simple protocol and easy to code once you get the patterns. If you want to code in C# a bit, well, BLE adapters for macOS and Linux are missing. |
- RGB Sensor - Tag Sensor #91 non-breaking
|
Hi @judavi Within the branch of the pull request #93 I started the implementation. I hope the following is completed
I added two examples to test them. For running the test do the following
Please perform the following tests
Note: Can you check the RGB color range. They are speced with 0..10 (raw) and 0..10 (SI). That invalidates basically the scaling ... i think the full byte range 0..255 is utilized, representing the full rgb spectrum (like done for the RgbLight). Would be nice if you can run the test case in the next days. I got request today for the TwoPortHub ... I would love to release a 3.1 version with both, Mario and TwoPortHub. Missing
The testing for this will be a bit rougher. |
|
Hi @tthiery ! For both scenarios (Go and C#) sounds really interesting!! Now! Let's talk about the specifics of the PR: Steps:
Results:
In this case _service is coming back with a null value. I'll try to debug but I just wanted to share what I saw in case you have an idea what it could be missing. About RGB Color Range: |
|
That is a bit strange especially considering that you already run the CLI on the same computer which runs over the same code. |
|
Cool! Let me try with those new values... |
|
No way... we will need to wait until tomorrow ... this guy is tired 😵
|
|
I notice two particular things but I'm still not sure how to fix those:
How we can get the correct systemTypeId ? And when is uncommented :
Probably as TechnicMediumHub with HardwareNetworkFamily in this case mario is not compatible with HardwareNetworkId. |
|
Are we sure is this a 0x43 ?
|
|
Well, the number is used in two enums. BLE Manufacturer data (which essentially instantiates the MarioHub class as a consequence) and as a SystemType property. These numbers match "usually". Try fixing the SystemType. |
|
Regards the network properties: branch on SystemType, exclude it for MarioHub. I will fix this more generic later. |
|
@judavi Hey, is Mario fit again? |
|
I added #121 which will help fixing the HardwareNetworkId issue. Will update this as soon as the other is in |
- HardwareNetworkId is not accepted by MarioHub #91 non-breaking
|
Added known property types. This should be fixed now. The other one I need more input from you. |
- Fix DataSet Formatting to query all dataset entries of a mode (instead of only the first like useful for motors) - Fix PortValueCombinedMode decoding to reflect this. - Fix MarioBarcode example - Temprary Constraint Percentage scaling #91 non-breaking
|
So MarioHub. I have to apologize. This was unexpected not a "good first issue". The library is/was not ready for the plumper. It is mostly working, however, there is still a lot to do ...
Further, a lot is strange with the device:
|
- MarioTagSensor reduce default delta interval to 3 to be able to scan blue color no #91
- Add MarioHub and related devices (Pants, TagSensor, Accelerometer/Gestures) - Add Mario Examples - Enable CombinedPortValue decoding with multiple data sets - Add capability to override default deltaInterval for notifications - Add capability to suppress percentage calculation (if e.g. data type overflow) #91 non-breaking
Mario seems to be a simple Lego Wireless Protocol compatible Powered Up device.
I cannot support this integration since I lack hardware. If anyone is up interesting trying to add, I will assist and guide.
The text was updated successfully, but these errors were encountered: