Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TwoPortHandset #119

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Add TwoPortHandset #119

merged 2 commits into from
Oct 27, 2020

Conversation

rickjansen-dev
Copy link
Contributor

@rickjansen-dev rickjansen-dev commented Oct 23, 2020 •
edited by tthiery
Loading

Closes #96 non-breaking

@rickjansen-dev rickjansen-dev mentioned this pull request Oct 23, 2020
Closed
tthiery
tthiery requested changes Oct 24, 2020
View reviewed changes
Copy link
Member

@tthiery tthiery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the Property Names and the Incoming PR

src/SharpBrick.PoweredUp/Hubs/TwoPortHandset.cs Show resolved Hide resolved
src/SharpBrick.PoweredUp/Hubs/Hub_Properties.cs Outdated Show resolved Hide resolved
src/SharpBrick.PoweredUp/Functions/DiscoverPorts.cs Outdated Show resolved Hide resolved
src/SharpBrick.PoweredUp/Devices/RemoteControlButton.cs Outdated Show resolved Hide resolved
@tthiery tthiery mentioned this pull request Oct 24, 2020
Merged
@tthiery tthiery added enhancement New feature or request area-hubs labels Oct 24, 2020
@rickjansen-dev rickjansen-dev force-pushed the issue-96-remote branch 3 times, most recently from 87d2d2a to a22b5c6 Compare October 26, 2020 15:30
@rickjansen-dev rickjansen-dev marked this pull request as ready for review October 26, 2020 15:46
@rickjansen-dev
Copy link
Contributor Author

I updated the PR. Most significant changes are in RemoteControlButton.

@tthiery
Copy link
Member

tthiery commented Oct 26, 2020

@vuurbeving All fine here except a stupid conflict in Program.cs of the examples project 😀

@rickjansen-dev
Copy link
Contributor Author

I resolved the conflicts in the examples

@tthiery tthiery merged commit 0c1cd4c into sharpbrick:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthiery tthiery tthiery approved these changes

Assignees

@rickjansen-dev rickjansen-dev

Labels
area-hubs enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RemoteControl (#88010)
2 participants
@rickjansen-dev @tthiery