Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Add sensible component default values for sliders #312

Closed
E3V3A opened this issue Mar 2, 2019 · 1 comment
Closed

Improvement: Add sensible component default values for sliders #312

E3V3A opened this issue Mar 2, 2019 · 1 comment

Comments

@E3V3A
Copy link

E3V3A commented Mar 2, 2019

As an improvement to prevent unexpected and nonsensical results when adding a slider to components, I suggest to add the components default values (as found under the components Edit menu), also to the default slider range.

In this respect I think the following function need to be modified to also accept (or take) other default values.

    Adjustable(CircuitElm ce, int item) {
	minValue = 1;
	maxValue = 1000;
	elm = ce;
	editItem = item;
}

Such an implementation would partially address issues such as:

@pfalstad
Copy link
Collaborator

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants