Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add Sliders" duty cycle default max should be 100 (not 1000) and phase offset default max should be 360 (not 1000) #681

Closed
ericfont opened this issue Nov 25, 2021 · 3 comments

Comments

@ericfont
Copy link

When create a voltage or current source and use a waveform like square wave, and then right click it and click "Sliders" and check the boxes for "Phase offset (degrees)" and "Duty Cycle", the form populates both of those max values at 1000 by default:

image

But these are not useful or reasonable default max values. More useful and reasonable default max values would be 100 for duty cycle (cause duty cycle can only run from 0% to 100%) and 360 for Phase offset (cause degrees go from 0 to 360 around a circle).

@pfalstad
Copy link
Collaborator

this is #312

@ericfont
Copy link
Author

oh yes, sorry for the duplicate issue.

@pfalstad
Copy link
Collaborator

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants