Implement IntoDartExceptPrimitive for bool (#47)

* Update into_dart.rs * Add tests * Add comment for #47 * Fix Clippy errors
shekohex · Sep 11, 2023 · c4e2bc4 · c4e2bc4
1 parent 57c81a2
commit c4e2bc4
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/src/ffi.rs b/src/ffi.rs
@@ -224,7 +224,7 @@ impl Drop for DartCObject {
 
 /// Exposed only for tests.
 #[doc(hidden)]
-pub unsafe fn run_destructors(obj: &mut DartCObject) {
+pub unsafe fn run_destructors(obj: &DartCObject) {
     use DartCObjectType::*;
     match obj.ty {
         DartExternalTypedData => unsafe {
@@ -241,7 +241,7 @@ pub unsafe fn run_destructors(obj: &mut DartCObject) {
                 )
             };
             for item in items {
-                run_destructors(&mut **item)
+                run_destructors(&**item)
             }
         },
         _ => {},

diff --git a/src/into_dart.rs b/src/into_dart.rs
@@ -101,6 +101,12 @@ impl IntoDart for bool {
     }
 }
 
+// https://github.com/sunshine-protocol/allo-isolate/pull/47
+//
+// Since Dart doesn't have a primitive list implemented for boolean (e.g. `Uint8List` for 8-bit unsigned int),
+// we should implement `IntoDartExceptPrimitive` for `bool` so that `Vec<bool>` can be converted to `List<bool>`.
+impl IntoDartExceptPrimitive for bool {}
+
 impl IntoDart for String {
     fn into_dart(self) -> DartCObject {
         let s = CString::new(self).unwrap_or_default();

diff --git a/tests/containers.rs b/tests/containers.rs
@@ -20,6 +20,8 @@ fn main() {
     assert!(!isolate.post(vec![42u64; 100]));
     assert!(!isolate.post(vec![42.0f32; 100]));
     assert!(!isolate.post(vec![42.0f64; 100]));
+    assert!(!isolate.post(vec![true; 100]));
+    assert!(!isolate.post(vec![false; 100]));
     assert!(!isolate.post(ZeroCopyBuffer(vec![42i8; 100])));
     assert!(!isolate.post(ZeroCopyBuffer(vec![42u8; 100])));
     assert!(!isolate.post(ZeroCopyBuffer(vec![42i16; 100])));
@@ -41,6 +43,8 @@ fn main() {
     assert!(!isolate.post([42u64; 100]));
     assert!(!isolate.post([42.0f32; 100]));
     assert!(!isolate.post([42.0f64; 100]));
+    assert!(!isolate.post([true; 100]));
+    assert!(!isolate.post([false; 100]));
     assert!(!isolate.post(ZeroCopyBuffer([42i8; 100])));
     assert!(!isolate.post(ZeroCopyBuffer([42u8; 100])));
     assert!(!isolate.post(ZeroCopyBuffer([42i16; 100])));
@@ -139,6 +143,8 @@ fn main() {
     assert!(isolate.post(vec![42u64; 100]));
     assert!(isolate.post(vec![42.0f32; 100]));
     assert!(isolate.post(vec![42.0f64; 100]));
+    assert!(isolate.post(vec![true; 100]));
+    assert!(isolate.post(vec![false; 100]));
     assert!(isolate.post(ZeroCopyBuffer(vec![42i8; 100])));
     assert!(isolate.post(ZeroCopyBuffer(vec![42u8; 100])));
     assert!(isolate.post(ZeroCopyBuffer(vec![42i16; 100])));
@@ -160,6 +166,8 @@ fn main() {
     assert!(isolate.post([42u64; 100]));
     assert!(isolate.post([42.0f32; 100]));
     assert!(isolate.post([42.0f64; 100]));
+    assert!(isolate.post([true; 100]));
+    assert!(isolate.post([false; 100]));
     assert!(isolate.post(ZeroCopyBuffer([42i8; 100])));
     assert!(isolate.post(ZeroCopyBuffer([42u8; 100])));
     assert!(isolate.post(ZeroCopyBuffer([42i16; 100])));