-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IntoDartExceptPrimitive
for bool
#47
Conversation
Could you please add a comment referring to this PR to explain why the |
Sure! I've added comments for this PR. There are some errors in the Clippy section of the CI test, should I change the code in that section? |
Sure, lets make these fixes. |
The error should now be fixed! |
Thank you! |
Thanks for your review, have a nice day! |
By the way, I'd like to know when this change will be released, as there's a PR blocked by this problem 😄. |
Yup, was planning to release it today, last night I was on phone. |
Released to the v0.1.19. |
Refer to fzyzcjy/flutter_rust_bridge#801 and fzyzcjy/flutter_rust_bridge#1353.
bool
should implementIntoDartExceptPrimitive
so thatVec<bool>
can be converted toList<bool>
, since Dart does not have a primitive list implemented for boolean (e.g.Uint8List
for 8-bit unsigned int).