Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Poetry, adopt tox and pytest #2127

Merged
merged 56 commits into from
Jun 9, 2024

Conversation

ppfeister
Copy link
Member

@ppfeister ppfeister commented May 20, 2024

Blocked by #2111 Partially consolidated. (Poetry review notes in original blocker, #2111)

tox now suitable (and recommended) for running unit tests across several environments at once with linting and coverage reporting.

Will be adopted by GitHub Actions later to remedy lost functionality from Poetry adoption.

@ppfeister ppfeister added enhancement New feature or request do not merge Don't merge this PR labels May 20, 2024
ppfeister and others added 9 commits May 31, 2024 14:46
Co-authored-by: Siddharth Dushantha <siddharth.dushantha@gmail.com>
When using tox, pass `-e offline` to exclude online tests.
When using pytest, pass `-m "not online"` to do the same.
@ppfeister
Copy link
Member Author

Rebased to #2111 feature/pyproj to fix conflicts
Can be merged as a standalone to include both changes or one after another for the same result

@ppfeister ppfeister marked this pull request as ready for review May 31, 2024 18:51
@ppfeister ppfeister removed the do not merge Don't merge this PR label May 31, 2024
ppfeister added 3 commits May 31, 2024 17:08
Workflow found to be ineffective after the removal of unclaimed_usernames. All sites skipped by tests due to the lack of this value, leading to false success of this test.

Workflow will be eventually rewritten following the new standard.
Workflow made redundant with the addition of Regression workflow, which runs on both push to and PR against master.
@ppfeister ppfeister changed the title Adopt tox and pytest Switch to Poetry, adopt tox and pytest Jun 1, 2024
pytest.ini Outdated Show resolved Hide resolved
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
ppfeister and others added 2 commits June 1, 2024 16:02
Co-authored-by: Siddharth Dushantha <siddharth.dushantha@gmail.com>
@ppfeister ppfeister requested a review from sdushantha June 1, 2024 20:10
@ppfeister ppfeister merged commit 3211b90 into sherlock-project:master Jun 9, 2024
15 checks passed
@ppfeister ppfeister deleted the feature/tox branch June 10, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants