Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ES6 with Node 4.0.0+ as engine #30

Closed
agraebe opened this issue May 18, 2016 · 2 comments
Closed

Using ES6 with Node 4.0.0+ as engine #30

agraebe opened this issue May 18, 2016 · 2 comments
Assignees
Milestone

Comments

@agraebe
Copy link
Collaborator

agraebe commented May 18, 2016

Right now, our tests in TravisCI cover (and pass) older versions of Node (0.10, 0.11, 0.12, iojs). I'm considering to use some ES6 features and wanted to understand you think there would be a tremendous drawback if we remove backward compatibility.

@shernshiou @puzzlehe4d

@shernshiou
Copy link
Owner

@agraebe yes that's my plan. That's the reason I am not developing in pre4.0.0 version anymore.

@agraebe
Copy link
Collaborator Author

agraebe commented May 19, 2016

Cool, how about we create a new branch for es6 development?

agraebe pushed a commit that referenced this issue Feb 26, 2017
@agraebe agraebe self-assigned this Feb 26, 2017
@agraebe agraebe added this to the v1.0.0 milestone Feb 26, 2017
@agraebe agraebe closed this as completed Feb 26, 2017
agraebe added a commit that referenced this issue Feb 26, 2017
* adding bluebird

missing tests

* adding tests for async methods

* #33 implementation including tests and updated README.md

* adding error handling to samples

* resolving conflict for README

* update dependency versions

* remove publisher and fix gulpfile

* #24 first piece with tests

to come: Reindeers & Requests implementation

* solving #24, #40, #41, #42

- added all methods for #24 including tests
- updated READMEs & example files
- reworked entire testing architecture for #41
- removed deprecated methods for #42
- added scope checks for #40

* adding tests for #40

* sync updates from master

* Added mechanism for token refresh (#47)

* added token refresh functionality

* added unit test for oauth.js

* added unit test for oauthAsync.js

* added tests for complete code coverage

* code cleanup

* Updating dependencies and set engines

* Setting tokens to fix #39

* Added implicit surge handling (#49)

* added functionality for surge pricing

* added implicit surge handling

* Changed OAuth2 urls to v2 (#53)

* Adding tests for #53

* Dropping node v.1x/iojs in favor of ES6 #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants