[Windows]windows_deploy.ymlのDLLコピー操作を削除 #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #516 +/- ##
========================================
Coverage 39.00% 39.00%
========================================
Files 247 247
Lines 12112 12112
========================================
Hits 4724 4724
Misses 7388 7388 ☔ View full report in Codecov by Sentry. |
shiosyakeyakini-info
merged commit 392a154
into
shiosyakeyakini-info:develop
1 check passed
|
マージしました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
今までインストーラーやZipファイルの作成時に
msvcp140.dll, vcruntime140.dll, vcruntime140_1.dllを含めるようコピーする操作を行っていたが、最近のリリースでは必要なライブラリが自動でReleaseディレクトリ以下にコピーされるようになっていた（api-ms-win-*.dllまで含める必要があるのかは不明）ため、DLLをコピーする操作をwindows_deploy.ymlから削除しました。