Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] 削除されていたDLLファイルを一部削除しないように #661

Conversation

Npepperlinux
Copy link
Contributor

@Npepperlinux Npepperlinux commented Nov 8, 2024

msvcp*.dll
vc*.dll
concrt*.dll
ucrtbas*.dll

上記をWindows用インストーラー作成前に削除しないように修正しました

Related to #516
Related to #610

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.69%. Comparing base (6955662) to head (560e829).
Report is 1 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #661   +/-   ##
========================================
  Coverage    27.69%   27.69%           
========================================
  Files          312      312           
  Lines        16253    16253           
========================================
  Hits          4501     4501           
  Misses       11752    11752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shiosyakeyakini-info shiosyakeyakini-info merged commit 064c549 into shiosyakeyakini-info:develop Nov 10, 2024
1 check passed
4ster1sk added a commit to 4ster1sk/miria that referenced this pull request Nov 10, 2024
…/fix/windows_dll_revert"

This reverts commit 064c549, reversing
changes made to aaec0b9.
@Npepperlinux Npepperlinux deleted the fix/windows_dll_revert branch December 10, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants