Fix retethering issue when anchor refs are removed #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (typeof selector === 'string') { | ||
| opts.element = document.querySelector(selector); | ||
| returnOpts.on = opts.on; | ||
| if (opts.offset !== 'undefined') { |
There was a problem hiding this comment.
opts.offset really ends up the string 'undefined'? That doesn't seem right (not saying your code is wrong, saying if that's the case, it should probably be fixed).
There was a problem hiding this comment.
oh good eye, i meant typeof here
| returnOpts.on = opts.on; | ||
| if (typeof opts.offset !== 'undefined') { | ||
| returnOpts.offset = opts.offset; | ||
| } |
There was a problem hiding this comment.
I think you can just do returnOpts = extend({}, opts)
There was a problem hiding this comment.
You're right - I got this confused with something else, it's only a single level of props so i wouldn't need deep copy anyway.
added 2 commits
February 4, 2016 17:35
|
@zackbloom anything else need tweaking before this is merged? |
|
👍 |
|
@zackbloom im going to merge this |
geoffdaigle
added a commit
that referenced
this pull request
Feb 5, 2016
Fix retethering issue when anchor refs are removed
|
Publishing as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zackbloom
I am working on a hubspot app that has a very dynamic, multi-page onboarding flow. The problem happens after the user finishes a flow and then decides to start it over. This situation might apply more broadly as well.
Current behavior (attaches to 0,0)
Fixed behavior (attaches to element)
The issue comes from the fact that the user options
opts.elementreference is overwritten when setting the element reference usingdocument.getQuerySelectorand stays in memory. Unless the steps are explicitly removed and added again (which, in practice, is not intuitive) the elements are never relieved of their reference and thus will always re-attach to the historical first reference that has no presence on the page.(Additionally, a deepNevermind that doesn't apply hereextendwould have worked nicely here but it seems like that doesn't happen in Tether utils).