-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix retethering issue when anchor refs are removed #95
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
/*! tether-shepherd 1.5.1 */ | ||
/*! tether-shepherd 1.5.2 */ | ||
|
||
(function(root, factory) { | ||
if (typeof define === 'function' && define.amd) { | ||
|
@@ -67,7 +67,6 @@ function matchesSelector(el, sel) { | |
var positionRe = /^(.+) (top|left|right|bottom|center|\[[a-z ]+\])$/; | ||
|
||
function parsePosition(str) { | ||
|
||
if (typeof str === 'object') { | ||
if (str.hasOwnProperty("element") && str.hasOwnProperty("on")) { | ||
return str; | ||
|
@@ -207,18 +206,23 @@ var Step = (function (_Evented) { | |
}, { | ||
key: 'getAttachTo', | ||
value: function getAttachTo() { | ||
var returnOpts = {}; | ||
var opts = parsePosition(this.options.attachTo) || {}; | ||
var selector = opts.element; | ||
|
||
if (typeof selector === 'string') { | ||
opts.element = document.querySelector(selector); | ||
returnOpts.on = opts.on; | ||
if (opts.offset !== 'undefined') { | ||
returnOpts.offset = opts.offset; | ||
} | ||
|
||
if (!opts.element) { | ||
throw new Error('The element for this Shepherd step was not found ' + selector); | ||
if (typeof opts.element === 'string') { | ||
// Can't override the element in user opts reference because we can't | ||
// guarantee that the element will exist in the future. | ||
returnOpts.element = document.querySelector(opts.element); | ||
if (!returnOpts.element) { | ||
throw new Error('The element for this Shepherd step was not found ' + opts.element); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm a little concerned that throwing an error may be more aggressive than is necessary. It might be better to use |
||
} | ||
} | ||
|
||
return opts; | ||
return returnOpts; | ||
} | ||
}, { | ||
key: 'setupTether', | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can just do
returnOpts = extend({}, opts)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right - I got this confused with something else, it's only a single level of props so i wouldn't need deep copy anyway.