Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] IDs must be removed and reinserted into wallets after spawning to work properly #3137

Closed
Anticept opened this issue Jun 21, 2024 · 3 comments · Fixed by #3196
Closed
Labels
Bug Something isn't working

Comments

@Anticept Anticept added the Bug Something isn't working label Jun 21, 2024
@FalloutFalcon
Copy link
Contributor

oops. dunno how this wasn't caught durning its many test merges. The you prob just need to refresh the wallet once you add the id should be a simple fix.

@Anticept
Copy link
Contributor Author

Not sure if it's related but every creature without an ID touching a door is also causing a runtime, it's trying to retrieve an ID that does not exist on the mob.

@Mirag1993
Copy link

need an update method in the combined access variable in the wallet

github-merge-queue bot pushed a commit that referenced this issue Jul 12, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Fixes runtimes caused by mobs without ids trying to open doors and
wallets not having there access untill you reinsert your wallet

IDs now send a signal that there access has been changed which wallets
listen for.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Fixes two bugs I caused!
Fixes #3137
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: pets no longer cause run times trying to open ship doors
fix: no longer have to reinsert your id into your wallet for access
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this issue Jul 13, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Fixes runtimes caused by mobs without ids trying to open doors and
wallets not having there access untill you reinsert your wallet

IDs now send a signal that there access has been changed which wallets
listen for.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Fixes two bugs I caused!
Fixes shiptest-ss13#3137
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: pets no longer cause run times trying to open ship doors
fix: no longer have to reinsert your id into your wallet for access
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants