Fix the git link for main branch #667
Conversation
openshift-ci-robot
added
the
kind/documentation
openshift-ci-robot
added
the
do-not-merge/release-note-label-needed
zhangtbj
added
release-note-none
| @@ -1,6 +1,11 @@ | |||
|
|
|||
There was a problem hiding this comment.
why the name change? we already change this twice.
There was a problem hiding this comment.
Was also confused, but based on Jordan's comment
Re-generate the crds by using the make generate-crds then change to the correct name and yaml format by using our agreed new controller-gen way.
this is how they are generated. I just ran make generare-crds locally and for me the files are also generated with the names that Jordan has in his commit.
There was a problem hiding this comment.
Interestingly, my generated files still contain the line breaks which I like more than the very long lines in Jordan's commit. Hm. @zhangtbj I got controller-gen installed via the hack/install-controller-gen.sh script. Do you maybe run a different version of the tool?
There was a problem hiding this comment.
Yes, I use the official make generare-crds command by following our doc.
The version I am using is (On Mac):
✘-1 $ ./controller-gen --version
Version: v0.4.1
Same as the version which is defined here: https://github.com/shipwright-io/build/blob/master/hack/install-controller-gen.sh#L14
There was a problem hiding this comment.
Funny detail. I just read newline discrepancy in CRDs generated by controller-gen #514 three times. They describe it the other way around. There, Mac output has line breaks, but Ubuntu not. You're on Mac while I am on Ubuntu and we observe it vice versa. They suggest to pipe through yq to prevent large git diffs, but that is not really nice as well. Honestly, this is one of these kinds of things where I wonder how the hack must the code look that produces such a discrepancy. lol
I think I approve, may the second reviewer decide if we can live with this.
There was a problem hiding this comment.
@zhangtbj but you are also adding new fields on the CRDS, might be an explanation on why will not hurt?
There was a problem hiding this comment.
I double check this. Its fine for me to keep the new names, code wise it make sense. I had a different opinion before, but I was on the wrong path.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Changes
Fix for issue: #666
Ref is a git reference. Optional. "master" is used by default.toRef is a git reference. Optional. If not defined, it will fallback to the git repository default branch.make generate-crdsthen change to the correct name and yaml format by using our agreed newcontroller-genway./kind documentation
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
None