Re-generate the crds by using line breaking

[zhangtbj]

Changes

This is a fix PR for the PR: #667

I also asked Matt and Zoe to verify, they also generate normally WITH line-breaking, but I tried several ways, all didn't work..... Finally, I gave up, I don't know why there is no line-breaking when I ran the make generate-crds in my local Mac.

Maybe because my Mac is more powerful than other ones. :(

Below is what I tried:

• Ask Matt and Zoe help, they can generate with line-breaking normally on the Mac
• I tried on Ubuntu, can also generate with line-breaking
• Then I tried to upgrade my Golang to 1.15, upgrade/downgrade, my controller-gen, change GOPATH, etc... they all didn't work

Because it is ONLY my Mac problem, so I provide this PR to change to the NORMAL format with line-breaking in this PR.

And I will follow the issue kubernetes-sigs/controller-tools#514 (comment) to see how to solve in future.

Thanks!

/kind misc

Submitter Checklist

• [ n ] Includes tests if functionality changed/was added
• [ n ] Includes docs if changes are user-facing
• [ y ] Set a kind label on this PR
• [ n ] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

None

[openshift-ci-robot]

@zhangtbj: The label(s) kind/misc cannot be applied, because the repository doesn't have them.

In response to this:

Changes

This is a fix PR for the PR: #667

I also asked Matt and Zoe to verify, they also generate normally WITH line-breaking, but I tried several ways, all didn't work..... Finally, I gave up, I don't know why there is no line-breaking when I ran the make generate-crds in my local Mac.

Maybe because my Mac is more powerful than other ones. :(

Below is what I tried:

• Ask Matt and Zoe help, they can generate with line-breaking normally on the Mac
• I tried on Ubuntu, can also generate with line-breaking
• Then I tried to upgrade my Golang to 1.15, upgrade/downgrade, my controller-gen, change GOPATH, etc... they all didn't work

Because it is ONLY my Mac problem, so I provide this PR to change to the NORMAL format with line-breaking in this PR.

And I will follow the issue kubernetes-sigs/controller-tools#514 (comment) to see how to solve in future.

Thanks!

/kind misc

Submitter Checklist

• [ n ] Includes tests if functionality changed/was added
• [ n ] Includes docs if changes are user-facing
• [ y ] Set a kind label on this PR
• [ n ] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zhangtbj]

/kind misc

[openshift-ci-robot]

@zhangtbj: The label(s) kind/misc cannot be applied, because the repository doesn't have them.

In response to this:

/kind misc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zhangtbj]

/kind cleanup

[qu1queee]

Thanks, I would like to see what @HeavyWombat thinks on this issue, before approving. PR looks good to me.

[HeavyWombat]

Thanks for looking into this.

To be honest, I was a bit confused at first and it was hard to tell whether the changes here are only whitespace changes. So I checked two things:

• from your branch, I ran make generate-crd and could confirm that on my system the created files match the ones in this branch
• used dyff to perform a whitespace independent diff on the YAMLs, which was also fine

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HeavyWombat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [HeavyWombat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment