-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-generate the crds by using line breaking #670
Re-generate the crds by using line breaking #670
Conversation
@zhangtbj: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind misc |
@zhangtbj: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind cleanup |
Thanks, I would like to see what @HeavyWombat thinks on this issue, before approving. PR looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this.
To be honest, I was a bit confused at first and it was hard to tell whether the changes here are only whitespace changes. So I checked two things:
- from your branch, I ran
make generate-crd
and could confirm that on my system the created files match the ones in this branch - used
dyff
to perform a whitespace independent diff on the YAMLs, which was also fine
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HeavyWombat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This is a fix PR for the PR: #667
I also asked Matt and Zoe to verify, they also generate normally WITH line-breaking, but I tried several ways, all didn't work..... Finally, I gave up, I don't know why there is no
line-breaking
when I ran themake generate-crds
in my local Mac.Maybe because my Mac is more powerful than other ones. :(
Below is what I tried:
Because it is ONLY my Mac problem, so I provide this PR to change to the NORMAL format with line-breaking in this PR.
And I will follow the issue kubernetes-sigs/controller-tools#514 (comment) to see how to solve in future.
Thanks!
/kind misc
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
None