Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreating a project with a custom domain makes it lose it #634

Closed
brokad opened this issue Feb 15, 2023 · 0 comments · Fixed by #637
Closed

Recreating a project with a custom domain makes it lose it #634

brokad opened this issue Feb 15, 2023 · 0 comments · Fixed by #637
Labels
Contribution Wanted The community is welcome to collaborate on this issue Good First Issue Good for newcomers

Comments

@brokad
Copy link
Collaborator

brokad commented Feb 15, 2023

Currently projects that have a registered custom domain with a TLS termination at the gateway service lose their custom domain status when you run cargo shuttle project rm && cargo shuttle project new. We'd like the custom domain status to remain even after such operations.

@brokad brokad added Good First Issue Good for newcomers Contribution Wanted The community is welcome to collaborate on this issue labels Feb 15, 2023
chesedo added a commit that referenced this issue Feb 22, 2023
* feat: restore previous custom domain (if any) when recreating project (#634)

* test: ProjectCreating fqdn dev-only getter and completed unit test

* refactor: remove Project::create in favour of internal builder pattern

* Update gateway/src/project.rs

---------

Co-authored-by: Pieter <pieter@chesedo.me>
@chesedo chesedo closed this as completed Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Wanted The community is welcome to collaborate on this issue Good First Issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants