(#634) restore custom domain when recreating project #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelorendina
commented
Feb 16, 2023
angelorendina
commented
Feb 17, 2023
Comment on lines
-204
to
-207
| pub fn create(project_name: ProjectName) -> Self { | ||
| Self::Creating(ProjectCreating::new_with_random_initial_key(project_name)) | ||
| } | ||
|
|
There was a problem hiding this comment.
(3rd commit proposal, can be removed if not liked)
Removing this public method as there is already a builder pattern for the inner ProjectCreating.
Alternatively one could change this method to accept a fqdn: Option<String> as well, to reflect the current usage of the method - I prefer the former though.
oddgrd
approved these changes
Feb 21, 2023
…#634) * test: ProjectCreating fqdn dev-only getter and completed unit test * refactor: remove Project::create in favour of internal builder pattern
|
@oddgrd thanks for the review. I have just rebased from latest master and squashed the commits into one, so it should be good to go as per your guidelines 👍 |
chesedo
approved these changes
Feb 22, 2023
|
Thanks for this @angelorendina! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: restore previous custom domain (if any) when recreating a project (closes #634)