-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Extend Hangfire Plugin with JobManager, Queue Support, and EF Health Check Integration #62
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to validate and test the hangfire changes. Initial impression so far is looking good.
PiBox.Hosting/WebHost/src/PiBox.Hosting.WebHost/Services/TypeImplementationResolver.cs
Outdated
Show resolved
Hide resolved
PiBox.Hosting/WebHost/test/PiBox.Hosting.WebHost.Tests/TypeImplementationResolverTests.cs
Outdated
Show resolved
Hide resolved
PiBox.Hosting/WebHost/test/PiBox.Hosting.WebHost.Tests/TypeImplementationResolverTests.cs
Outdated
Show resolved
Hide resolved
PiBox.Hosting/WebHost/test/PiBox.Hosting.WebHost.Tests/TypeImplementationResolverTests.cs
Outdated
Show resolved
Hide resolved
PiBox.Plugins/Jobs/Hangfire/src/PiBox.Plugins.Jobs.Hangfire/HangFirePlugin.cs
Show resolved
Hide resolved
i've also adjusted the test method "GetInaccessibleValue" to be able to look for properties/fields on base type. |
@lukas-kd We'll still need a couple days before we can test the changes as we're short on resources right now and priority doesn't open up much space. I'm certain there won't be that many comments or necessary alterations though. In general we can talk about your expectations in regards to PR reviews so we can find a good middleground between testing on our side and not slowing you down/blocking any of your features. |
This PR enhances the Hangfire plugin by introducing a JobManager to orchestrate the various Hangfire job clients (BackgroundJobClient, RecurringJobManager, JobStorage) into a single, unified manager.
Key Changes:
JobManager: Centralized manager for handling Hangfire job clients.
Attribute Configuration: Replaced the JobRegister and moved Timeout and TimeZone configurations to attribute-based setup for more flexible job management.
Queue Support: Added support for specifying job queues, allowing better control over job execution order and prioritization.
Other improvements:
Entity Framework Health Check: Integrated automatic health check registration for Entity Framework, enhancing monitoring and resilience.
WebHost Configurators: Allows to implement configurators for plugins to allow more custom configuration.