fix: augment vue rather than @vue/runtime-core
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes augmentations of `@vue/runtime-core` in favour of only augmenting vue, which should fix issues when other packages (like `vue-router`) are only augmenting `vue` (see nuxt/nuxt#28542)
✅ Deploy Preview for vue-to-print ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @siaikin ! Thanks for your library! Recent nuxt upstream changes broke the types. Could we please get a new release with this fix 🙏🏼 |
|
Thank you very much for your pr🥳.
I'm sorry that I didn't reply soon, because of the jet lag, I just got up now🥱.
I will check your pr and merge it immediately.
发自我的 iPhone
在 2024年8月23日，04:21，miguelrk ***@***.***> 写道：
Hey @siaikin<https://github.com/siaikin> ! Thanks for your library! Recent nuxt upstream changes broke the types. Could we please get a new release with this fix 🙏🏼
—
Reply to this email directly, view it on GitHub<#8 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AF42KDAYWVKZY6VHNXXA2MLZSZB47AVCNFSM6AAAAABM6JSAGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGU3DEOJZGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: after nuxt/nuxt#28446, the mixing of module augmentation causes issues for modules downstream like
vue-to-printwhich cause typescript intellisense to break completely (e.g. in vscode).Solution: this PR removes augmentations of
@vue/runtime-corein favour of only augmentingvue(the new recommendation), which should fix issues when other packages (likevue-to-print) are only augmentingvue(see nuxt/nuxt#28542)