fix(nuxt): only augment vue, not sub-packages
#28542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Aug 15, 2024
|
/trigger release |
|
So just to be sure, we're sticking with augmenting There may be a way for users to still have working types while modules are catching up, see https://stackblitz.com/edit/github-dz3tm4-brftas?file=pages%2Findex.vue,nuxt.config.ts,shim.d.ts. Maybe this causes other issues, I haven't tested it thoroughly 🤷♂️ |
This was referenced Aug 16, 2024
This was referenced Aug 20, 2024
Roman3349
added a commit
to Roman3349/vue3-toastify
that referenced
this pull request
Aug 22, 2024
See: nuxt/nuxt#28542 Signed-off-by: Roman Ondráček <mail@romanondracek.cz>
miguelrk
added a commit
to miguelrk/vue-to-print
that referenced
this pull request
Aug 22, 2024
This removes augmentations of `@vue/runtime-core` in favour of only augmenting vue, which should fix issues when other packages (like `vue-router`) are only augmenting `vue` (see nuxt/nuxt#28542)
n0099
added a commit
to n0099/open-tbm
that referenced
this pull request
Aug 23, 2024
…#28446 and nuxt/nuxt#28542 @ fe $ composer update @ be
n0099
added a commit
to n0099/open-tbm
that referenced
this pull request
Aug 25, 2024
…t/nuxt#28446 * fix class `ms-1` only occurs on not-2th username @ `<PostBadgeThreadAuthorAndLatestReplier>` - prop `expandRowByClick` of `<ATable>` @ <PostRendererTable>` * widden the type of param `name` of `routeNameWithCursor()` and guard it against `assertRouteNameIsStr()` to be like `routeNameWithoutCursor()` * only return the modified route name and param `cursor` without any parts like `query` or other params from param `route` @ `getNextCursorRoute()` @ router.ts * fix regression of 0917db2 as `defineOgImageComponent()` now seem being able to `unref()` internally: nuxt-modules/og-image#190 @ post/seo/index.ts @ utils @ fe
7 tasks
tsukumijima
added a commit
to tsukumijima/NX-Jikkyo
that referenced
this pull request
Aug 29, 2024
"@vue/runtime-core" ではなく "vue" の型を拡張しないとすべての型が壊れてしまう ref: nuxt/nuxt#28542
tsukumijima
added a commit
to tsukumijima/KonomiTV
that referenced
this pull request
Aug 29, 2024
"@vue/runtime-core" ではなく "vue" の型を拡張しないとすべての型が壊れてしまう ref: nuxt/nuxt#28542
ascott18
added a commit
to IntelliTect/Coalesce
that referenced
this pull request
Sep 5, 2024
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #28561
📚 Description
This removes augmentations of
@vue/runtime-corein favour of only augmenting vue, which should fix issues when other packages (likevue-router) are only augmenting vue (release notes).This may cause issues until the ecosystem moves away from other augments.