Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: augment @vue/runtime-core #365

Closed
wants to merge 1 commit into from
Closed

fix: augment @vue/runtime-core #365

wants to merge 1 commit into from

Conversation

danielroe
Copy link
Member

resolves nuxt/nuxt#28440

Investigating the type issues in latest vue/vue-router projects, I think we need to augment @vue/runtime-core, as these types will flow 'up' into the vue types (example), but - in some cases - not the other way around (see vuejs/router#2341 and the linked reproduction).

@antfu
Copy link
Member

antfu commented Aug 15, 2024

Well, this is so tricky, we moved back and forth so many times:

After reading nuxt/nuxt#28542 it makes me even more confused. I vaguely remember at some version of Vue we start to recommend always augmenting against vue. Now we are moving back again, or only for certain types?

@danielroe
Copy link
Member Author

I think this is actually my mistake, and the current behaviour is correct. 🤦

@danielroe danielroe closed this Aug 15, 2024
@danielroe danielroe deleted the fix/runtime-core branch August 15, 2024 17:31
@ThomasBerneHCSE
Copy link

ThomasBerneHCSE commented Aug 26, 2024

Then if it is the correct behavior, how do you explain the error some people (like me) encounters in this issue @danielroe: nuxt/nuxt#28440 ? (And stil experiencing the issue in nuxt 3.13.0)

@danielroe
Copy link
Member Author

@ThomasBerneHCSE it requires every library to augment vue and not @vue/runtime-core. If you are using a library that doesn't, its code also needs to be updated.

@ThomasBerneHCSE
Copy link

Ok Thanks for the quick answer. It seems to be the case for vuetify. I'm opening an issue on their side.

@douglasg14b
Copy link

@ThomasBerneHCSE Can you like the vuetify ticket to this one?

@ThomasBerneHCSE
Copy link

It has been fixed in vuetify 3.7.1. Just update to the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error with vue-tsc 2.0.29
4 participants