Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envFile support for system-extensions #7316

Closed
btrepp opened this issue Jun 3, 2023 · 1 comment · Fixed by #7408
Closed

envFile support for system-extensions #7316

btrepp opened this issue Jun 3, 2023 · 1 comment · Fixed by #7408

Comments

@btrepp
Copy link

btrepp commented Jun 3, 2023

Feature Request

Talos extensions currently support setting env vars for the container, however there doesn't appear to be an 'envFile' equivalent.
This means extensions that require some sort of 'configuration' have to write their own wrappers

It would be great if there would be an enhancement to extensions that allows for 'envFiles'. That could set the containers environment.

Description

This was encountered in the below extension, where I wanted to allow consumers to configure things like a Tailscale key.
From : siderolabs/extensions#154

The workaround I used there was an existing exe inside the container, that forks out to the process after setting the environment. It's also possibly to write wrapper exe's that do similar.

Having this feature added would mean future extensions don't have to write wrappers as often, and also allow some already containerised friendly apps to work out of the box (eg ones that support env vars).

@frezbo
Copy link
Member

frezbo commented Jun 3, 2023

This seems a valid ask 👍

frezbo added a commit to frezbo/talos that referenced this issue Jun 27, 2023
Supports setting `environmentFile` for Talos System Extension Services.

Fixes: siderolabs#7316

Signed-off-by: Noel Georgi <git@frezbo.dev>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants