Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support environment file for extensions #7408

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

frezbo
Copy link
Member

@frezbo frezbo commented Jun 27, 2023

Supports setting environmentFile for Talos System Extension Services.

Fixes: #7316

frezbo pushed a commit to btrepp/extensions that referenced this pull request Jun 27, 2023
Tailscale as a system service extension.
Creates network devices in the talos 'host'

Requires: siderolabs/talos#7408

Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo pushed a commit to btrepp/extensions that referenced this pull request Jun 27, 2023
Tailscale as a system service extension.
Creates network devices in the talos 'host'

Requires: siderolabs/talos#7408

Signed-off-by: Noel Georgi <git@frezbo.dev>
@frezbo
Copy link
Member Author

frezbo commented Jun 27, 2023

Tested with the tailscale extension:
tailscale

❯ talosctl -n 10.5.0.3 get links 
NODE       NAMESPACE   TYPE         ID                VERSION   TYPE       KIND     HW ADDR                                           OPER STATE   LINK STATE
10.5.0.3   network     LinkStatus   bond0             1         ether      bond     aa:01:84:18:4c:16                                 down         false
10.5.0.3   network     LinkStatus   dummy0            1         ether      dummy    7a:6e:05:f7:17:63                                 down         false
10.5.0.3   network     LinkStatus   enx966a24fb42ad   4         ether               96:6a:24:fb:42:ad                                 up           true
10.5.0.3   network     LinkStatus   flannel.1         3         ether      vxlan    02:6a:25:4c:79:e3                                 unknown      true
10.5.0.3   network     LinkStatus   ip6tnl0           1         tunnel6    ip6tnl   00:00:00:00:00:00:00:00:00:00:00:00:00:00:00:00   down         false
10.5.0.3   network     LinkStatus   lo                2         loopback            00:00:00:00:00:00                                 unknown      true
10.5.0.3   network     LinkStatus   sit0              1         sit        sit      00:00:00:00                                       down         false
10.5.0.3   network     LinkStatus   tailscale0        4         nohdr      tun                                                        unknown      true
10.5.0.3   network     LinkStatus   teql0             1         void                                                                  down         false
10.5.0.3   network     LinkStatus   tunl0             1         ipip       ipip     00:00:00:00                                       down         false
❯ talosctl -n 10.5.0.3 get addresses
NODE       NAMESPACE   TYPE            ID                                                       VERSION   ADDRESS                                       LINK
10.5.0.3   network     AddressStatus   enx966a24fb42ad/10.5.0.3/24                              1         10.5.0.3/24                                   enx966a24fb42ad
10.5.0.3   network     AddressStatus   enx966a24fb42ad/fe80::946a:24ff:fefb:42ad/64             2         fe80::946a:24ff:fefb:42ad/64                  enx966a24fb42ad
10.5.0.3   network     AddressStatus   flannel.1/10.244.1.0/32                                  1         10.244.1.0/32                                 flannel.1
10.5.0.3   network     AddressStatus   flannel.1/fe80::6a:25ff:fe4c:79e3/64                     2         fe80::6a:25ff:fe4c:79e3/64                    flannel.1
10.5.0.3   network     AddressStatus   lo/127.0.0.1/8                                           1         127.0.0.1/8                                   lo
10.5.0.3   network     AddressStatus   lo/::1/128                                               1         ::1/128                                       lo
10.5.0.3   network     AddressStatus   tailscale0/100.105.xx.x/32                               1         100.105.xx.x/32                               tailscale0
10.5.0.3   network     AddressStatus   tailscale0/fd7a:115c:a1e0:ab12:4843:cd96:6269:4f02/128   1         fd7a:115c:a1e0:ab12:4843:cd96:6269:4f02/128   tailscale0
10.5.0.3   network     AddressStatus   tailscale0/fe80::3818:cf1b:a917:dbb3/64                  1         fe80::3818:cf1b:a917:dbb3/64                  tailscale0

And if the environment file is absent, the extensions waits:

[   10.189243] [talos] service[ext-tailscale](Waiting): Waiting for file "/var/etc/tailscale/auth.env" to exist

Supports setting `environmentFile` for Talos System Extension Services.

Fixes: siderolabs#7316

Signed-off-by: Noel Georgi <git@frezbo.dev>
@frezbo frezbo force-pushed the feat/extension-service-envfile branch from d3f26da to cbdf96d Compare June 27, 2023 18:51
btrepp added a commit to btrepp/extensions that referenced this pull request Jun 28, 2023
Tailscale as a system service extension.
Creates network devices in the talos 'host'

Requires: siderolabs/talos#7408

Signed-off-by: Noel Georgi <git@frezbo.dev>
Signed-off-by: beau trepp <beautrepp@gmail.com>
@smira smira added this to the v1.5 milestone Jun 28, 2023
@frezbo
Copy link
Member Author

frezbo commented Jun 28, 2023

/m

@talos-bot talos-bot merged commit cbdf96d into siderolabs:main Jun 28, 2023
5 checks passed
@frezbo frezbo deleted the feat/extension-service-envfile branch June 28, 2023 15:25
frezbo pushed a commit to btrepp/extensions that referenced this pull request Jun 28, 2023
Tailscale as a system service extension.
Creates network devices in the talos 'host'

Requires: siderolabs/talos#7408

Signed-off-by: Noel Georgi <git@frezbo.dev>
Signed-off-by: beau trepp <beautrepp@gmail.com>
Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo pushed a commit to btrepp/extensions that referenced this pull request Jun 28, 2023
Tailscale as a system service extension.
Creates network devices in the talos 'host'

Requires: siderolabs/talos#7408

Signed-off-by: Noel Georgi <git@frezbo.dev>
Signed-off-by: beau trepp <beautrepp@gmail.com>
Signed-off-by: Noel Georgi <git@frezbo.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

envFile support for system-extensions
3 participants