Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SideroLink endpoint to Talos dashboard #8643

Closed
Tracked by #8484
rothgar opened this issue Apr 23, 2024 · 1 comment · Fixed by #8909
Closed
Tracked by #8484

Add SideroLink endpoint to Talos dashboard #8643

rothgar opened this issue Apr 23, 2024 · 1 comment · Fixed by #8909
Assignees

Comments

@rothgar
Copy link
Member

rothgar commented Apr 23, 2024

Feature Request

It would be great to have the SideroLink domain available in the console dashboard (when used). Because the API is locked down to Omni/SideroLink we need to know where that configuration can come from.

Description

An example config that might work in the dashboard
image

We could show status of the link (if there's room), but it's probably easier just to show the status with a font/color eg (red and italicized for disconnected and green and bold for connected). I mention using a font because I am red green color blind and if we only rely on colors it can cause problems. Another option for status is a unicode check ✓ (U+2713) and ✗ (U+2717) if those characters are available.

@smira
Copy link
Member

smira commented Apr 23, 2024

Unicode characters are fun with Linux console, as it usually doesn't have full Unicode font, but rather maps some Unicode glyphs to the font entries. (But Unicode is fine when talosctl dashboard runs in the terminal).

@utkuozdemir utkuozdemir self-assigned this Jun 12, 2024
utkuozdemir added a commit to utkuozdemir/talos that referenced this issue Jun 14, 2024
Add a new resource, `SiderolinkStatus`, which combines the following info:
- The Siderolink API endpoint without the query parameters or fragments (potentially sensitive info due to the join token)
- The status of the Siderolink connection

This resource is not set as sensitive, so it can be retrieved by the users with `os:operator` role (e.g., using `talosctl dashboard` through Omni).

Make use of this resource in the dashboard to display the status of the Siderolink connection.

Additionally, rework the status columns in the dashboard to:
- Display a Linux terminal compatible "tick" or a "cross" prefix for statuses in addition to the red/green color coding.
- Move and combine some statuses to save rows and make them more even.

Closes siderolabs#8643.

Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
utkuozdemir added a commit to utkuozdemir/talos that referenced this issue Jun 14, 2024
Add a new resource, `SiderolinkStatus`, which combines the following info:
- The Siderolink API endpoint without the query parameters or fragments (potentially sensitive info due to the join token)
- The status of the Siderolink connection

This resource is not set as sensitive, so it can be retrieved by the users with `os:operator` role (e.g., using `talosctl dashboard` through Omni).

Make use of this resource in the dashboard to display the status of the Siderolink connection.

Additionally, rework the status columns in the dashboard to:
- Display a Linux terminal compatible "tick" or a "cross" prefix for statuses in addition to the red/green color coding.
- Move and combine some statuses to save rows and make them more even.

Closes siderolabs#8643.

Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
utkuozdemir added a commit to utkuozdemir/talos that referenced this issue Jun 14, 2024
Add a new resource, `SiderolinkStatus`, which combines the following info:
- The Siderolink API endpoint without the query parameters or fragments (potentially sensitive info due to the join token)
- The status of the Siderolink connection

This resource is not set as sensitive, so it can be retrieved by the users with `os:operator` role (e.g., using `talosctl dashboard` through Omni).

Make use of this resource in the dashboard to display the status of the Siderolink connection.

Additionally, rework the status columns in the dashboard to:
- Display a Linux terminal compatible "tick" or a "cross" prefix for statuses in addition to the red/green color coding.
- Move and combine some statuses to save rows and make them more even.

Closes siderolabs#8643.

Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
utkuozdemir added a commit to utkuozdemir/talos that referenced this issue Jun 18, 2024
Add a new resource, `SiderolinkStatus`, which combines the following info:
- The Siderolink API endpoint without the query parameters or fragments (potentially sensitive info due to the join token)
- The status of the Siderolink connection

This resource is not set as sensitive, so it can be retrieved by the users with `os:operator` role (e.g., using `talosctl dashboard` through Omni).

Make use of this resource in the dashboard to display the status of the Siderolink connection.

Additionally, rework the status columns in the dashboard to:
- Display a Linux terminal compatible "tick" or a "cross" prefix for statuses in addition to the red/green color coding.
- Move and combine some statuses to save rows and make them more even.

Closes siderolabs#8643.

Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants