-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show siderolink status on dashboard #8909
feat: show siderolink status on dashboard #8909
Conversation
could you add a screenshot? |
internal/app/machined/pkg/controllers/siderolink/status_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆒
sure, will do a bit later |
and to make it perfect, screenshot from QEMU - if you need help with that, I can try it out myself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for a screenshot, cool 👍
let me know if you need help with QEMU
Nope, all good, just AFK for a while. I'll provide both screenshots. |
0d27f1a
to
6a06f53
Compare
what does that even mean by |
It reports if the state partition is mounted. Also, if it's encrypted, it looks like It's been there since a long time. I agree that it my itself doesn't make too much sense, but the encryption info is good. |
ahh now I remeber, the |
One small nit: let's drop the protocol/port from the SideroLink, just the hostname. It helps to identify Omn instance, but it's not meant to provide the full URL |
I'd say drop it... probably we could later merge Secureboot/disk encryption into something more helpful, like "Security: Secureboot/Disk encryption" |
6a06f53
to
ca8b017
Compare
Add a new resource, `SiderolinkStatus`, which combines the following info: - The Siderolink API endpoint without the query parameters or fragments (potentially sensitive info due to the join token) - The status of the Siderolink connection This resource is not set as sensitive, so it can be retrieved by the users with `os:operator` role (e.g., using `talosctl dashboard` through Omni). Make use of this resource in the dashboard to display the status of the Siderolink connection. Additionally, rework the status columns in the dashboard to: - Display a Linux terminal compatible "tick" or a "cross" prefix for statuses in addition to the red/green color coding. - Move and combine some statuses to save rows and make them more even. Closes siderolabs#8643. Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
ca8b017
to
5ffc3f1
Compare
/m |
Add a new resource,
SiderolinkStatus
, which combines the following info:This resource is not set as sensitive, so it can be retrieved by the users with
os:operator
role (e.g., usingtalosctl dashboard
through Omni).Make use of this resource in the dashboard to display the status of the Siderolink connection.
Additionally, rework the status columns in the dashboard to:
Closes #8643.
Screenshots