-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vue): add vue support #291
Conversation
@PhentomPT in one of your latest JF we decided to ignore vue for now (#105 (comment)). Is there any new reason to implement the wrapper? |
@danielleroux yes, here is a list on some important reasons
|
We have to clarify this in the next jourfix |
@danielleroux MR is ready |
This is one of our main goals for 1.5.0 but as discussed in last team jf we have first to make the update to stencil v3.0.0 (#327) |
I resolve merge conflicts after #431 is merged to main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Maybe we have to adapt the installation disclaimer after merge.
Vue3 support
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn test
) were run locally and passedyarn visual-regression
) were run locally and passednpm lint
) was run locally and passedPull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information
Assets
Packages
Docs
Preview examples