CI: Remove CircleCI #1317
Merged
CI: Remove CircleCI #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there something else we need to remove in our github config to make this go away? |
|
Working on the updates right now. Give me a minute |
|
Okay, I updated the required checks and deleted the circle ci webhook. Should be good to land this now and we can see if CircleCI creates errors for future PRs |
V-FEXrt
approved these changes
Jun 26, 2023
| @@ -83,7 +83,7 @@ jobs: | |||
| docker_builds: | |||
| runs-on: ubuntu-latest | |||
| needs: tarball | |||
| name: Docker Build (${{ matrix.target }}) | |||
There was a problem hiding this comment.
I think (?) this name is load bearing in terms of the 'required' checks for GitHub actions. It doesn't seem to be effecting this PR so it's probably okay but we may need to tweak the settings after this lands
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rational for keeping CircleCI was that they provided virtual machine images running an old enough kernel to pair with some of the older docker image distros that we were testing.
It looks like we're not actually using an old enough virtual machine anymore, so I think this is redundant.
There is a webhook in github's
Settingstab for this repository that would need to be disabled if we were to merge this PR.