-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_playlist()
format update
#562
Comments
Yeah, same issue as with get_album. Thanks for the helpful data |
It seems your screenshot is for a public playlist and your response data for a different private playlist? And the title of the private playlist is Title with description Description? Could you please also provide response data for a public playlist? And a screenshot for the private one if you don't mind (feel free to copy a public playlist to a private one if you mind the privacy). It would be helpful to have matching screenshot & response data for both private and public playlist to be able to make some sense of it. |
hey, sorry for late reply. and also i've opened playlist for everyone with the link: https://music.youtube.com/playlist?list=PLaZPMsuQNCsWn0iVMtGbaUXO6z-EdZaZm |
the attached link looks different to me, not sure if it's because i'm not signed in i'm trying to copy playlists from spotify to yt music, it's not working due to this issue i tried to adapt https://github.com/sigma67/ytmusicapi/tree/fix-get-album-544, however i'm finding that the structure of the json is quite a bit different from what the code is expecting 🤷♂️ |
@jbrodriguez you cannot reproduce it with your own account if you're not part of Google's A/B group for this test You'll have to work with the JSON provided by affected users until the change is generally available |
@sigma67 got it ! i tinkered with it and fixed it for me (i copied playlists of ~500 songs without issues) here's the patch for the fix, although as you mentioned it may work for my scenario (private playlists), it may not work for a general case (including public playlists) 0001-fix-get_playlist-functionality.patch i'm posting it here as a reference, because i saw that there's some refactoring already in place regarding the playlist header |
You guys could help by providing more test data:
So far I only have a private playlist from a comment by @heisen273 CC @apastel |
Public playlist: Private playlist: Let me know if you need anything else 🤝 |
Hi @apastel, thanks, that's already helpful! What I meant though is a public playlist that is not owned by you. So the actual distinction here is between an "owned" and a "foreign" playlist, as that will make a difference in how it is presented to the user. Could you provide a foreign playlist, i.e. one that you do not own, like one generated by YouTube Music? |
Whoops, yes that's an important distinction: |
@apastel are you maybe not in the A/B test anymore? Your data is actually not the new format, but the old one It has If you still have the error, maybe it is a different one? In that case can you screenshot the playlist? |
My bad (again), I forgot that my failing unit tests are using my "Test Brand" account, and I just gave you a playlist while logged into my personal account. I can see that this json file contains the Let me know if you still need a private two-column playlist. |
Trying to provide more data: And public playlist files (I'm not the owner): |
(Issue originated from this comment).
Currently
get_playlist()
breaks with same KeyError as in #544@sigma67 , As per your request, here's playlist screenshot
and full response dict:
response.json
The text was updated successfully, but these errors were encountered: