Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #544 #560

Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix #544 #560

merged 2 commits into from
Apr 5, 2024

Conversation

sigma67
Copy link
Owner

@sigma67 sigma67 commented Mar 7, 2024

closes #544

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.92%. Comparing base (90d172b) to head (2c3ef94).

Files Patch % Lines
ytmusicapi/parsers/albums.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   95.78%   95.92%   +0.13%     
==========================================
  Files          36       36              
  Lines        2136     2157      +21     
==========================================
+ Hits         2046     2069      +23     
+ Misses         90       88       -2     
Flag Coverage Δ
unittests 95.92% <96.42%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heisen273
Copy link

heisen273 commented Mar 9, 2024

hey, i have same keyerror in get_playlist() method._.

Screenshot 2024-03-09 at 21 45 42

response structure(sorry for screenshot, it's too big to paste in here):
Screenshot 2024-03-09 at 21 47 28

after spending some time on this, i've found that this

results = nav(response, TWO_COLUMN_RENDERER + ["secondaryContents"] + SECTION_LIST_ITEM + ["musicPlaylistShelfRenderer"])

fixes the issue, but then other logics(own_playlist var, ...) breaks._.
hope this helps at least somehow. pls let me know if i should share full raw response payload with you.

@sigma67
Copy link
Owner Author

sigma67 commented Mar 10, 2024

Yes, please share. Also share a screenshot of that playlist

Please do so in a separate issue

@sigma67 sigma67 merged commit 2217f3d into main Apr 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_album format update
2 participants