-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure on aarch64 (M1 Macbook) #6063
Comments
Sorry about that. Could you try installing node 16.13.2 and giving it another go, please? |
It would be so awesome if there would be an offical Signal distribution for aarch64 (M1).... |
For macOS there is, the version at https://signal.org/download/ is universal. If you're already using Signal Desktop on an Apple silicon device, I think the auto-updater should've updated you to the native version already. For official support of |
I've given that a try, also failed:
|
@WhyNotHugo ah, I see now! Did you install |
Yes,
|
@WhyNotHugo If you tried a |
I didn't, but I'm doing each subsequent run from scratch anyway to avoid any issues like that. |
I was able to successfully build, install and run Signal on Asahi Linux, using the Arch Linux AUR package If someone is new to Arch Linux / Asahi and needs help to apply the fix and build and install the package, let me know. |
@mkurz Thanks for digging into this! I see that the main difference with this patch is that you build using the system I'm asking here mostly because if an old version is pinned somewhere, it would be great to investigate where, so it can be fixed upstream too. |
@WhyNotHugo to be honest: I have no idea where yarn gets |
Hope we can get this patch in |
I digged a bit deeper and think I know how this fpm problem can be fixed. Step by step:
So what needs to be done is:
I am not going to do that, so if someone wants to take over from here, feel welcome to do so. BTW: About
|
Quick note, app-builder-bin dependency can't be upgraded in Electron-builder until this issue is resolved: develar/app-builder#83 |
@mkurz Thanks for digging through this and figuring out all the lose ends, that's quite some detailed research! |
@WhyNotHugo Happy to help. However I don't have more time to fix that. I hope someone picks up from here. I think it's pretty clear and straight forward what needs to be done. |
Perhaps a saner approach would be to rely on system packages or building from source, rather than pull binaries from various online sources and executing them. Pulling binaries from upstream will continuously have new issues on different architectures, and upstream can't be expected to build for all of them. Plus, pulling binaries from a bunch of different sources definitely can't be a secure thing to do. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
bump |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
asadfads |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Ah yes, my periodic email reminder of why automatic stale bots are awful for the world of open source... (Bump, not stale as far as I can tell) |
activity occurs
|
any news on this? |
Still not working for me.. |
I've never attempted myself, but aarch64 appears to be building fine for the |
How can we build the Signal beta on Fedora Asahi? |
It looks like perhaps the instructions on CONTRIBUTING.md have changed since this post was originally opened. I did a fresh clone of the repo, checked out release v7.0.0, made sure I had gcc g++, python3 and make and still was met with some errors attempting to install from a frozen file lock with yarn. These days it looks like there's 3 packages that do not work correctly with ARM causing errors, electron-builder, canvas, and fs-attr. It looks like fs-attr is an optional dependency so it might work without that? electron-builder though has a name like it might be important to an electron app 🙂 Output of yarn debug log:
|
Hello! The main problem was with fpm package that require electron during build I am very thankful to this topics: The main repo of aarm64 build, my hero! Main longread explanation how it works: So, the solution is to build fpm by yourself and build any electron apps for aarm64 after.
|
A potential solution would be to have binary packages for fpm-arm-binary for the distribution used by CI. |
https://github.com/electron-userland/electron-builder-binaries/ The official repo electron-builder-binaries has only x86-x64 built fpm binary but not arm64. Author of this repo fpm-arm-binaries haven't posted it yet. So for now it's only way to build yorself. It's possible to ask him maybe to post binaries in his repo. Upd: I asked to add binaries. |
Bug Description
Trying to build from source on
aarch64
fails:An identical setup on amd64 works fine.
Steps to Reproduce
Essentially following build steps
Actual Result:
Build fails on
aarch64
, but work on an equivalentamd64
setup (e.g.: same packages, same versions, but everything built for that architecture).Expected Result:
Should build fine?
Screenshots
n/a
Platform Info
Signal Version: 5.53.0
Operating System:
Linux 5.19.0-asahi-1-1-ARCH aarch64 GNU/Linux
Linked Device Version: n/a
Link to Debug Log
n/a
Related issues:
There's a few other issues, but more of them discuss unofficial binaries, or requesting shipped binaries. They're not about an actual crash when building.
The text was updated successfully, but these errors were encountered: