This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Make cloud provider metadata log more robust #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrcamp
reviewed
Mar 4, 2021
keitwb
reviewed
Mar 4, 2021
jrcamp
approved these changes
Mar 4, 2021
|
updated to remove |
|
That didn't seem to make them happy yet. |
|
@keitwb signalfx-agent/tests/helpers/assertions.py Line 186 in 3d1c91b And the only error log I have changed is after the initial connection succeeding https://github.com/signalfx/signalfx-agent/pull/1620/files#diff-5c32148c814c31d5bd8804f4de667e16e11040ec1e9190a18373e301a1ab772aR33 |
Signed-off-by: Dani Louca <dlouca@splunk.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set the first error to info and the rest to Error.
If we made it through the curl, this means that we are on AWS, so the anything error later on is an accurate error
cc: @jrcamp @keitwb
Signed-off-by: Dani Louca dlouca@splunk.com