Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI warns about deprecated Node.js v12 in setup-protoc #3705

Closed
michaelsproul opened this issue Nov 9, 2022 · 0 comments
Closed

CI warns about deprecated Node.js v12 in setup-protoc #3705

michaelsproul opened this issue Nov 9, 2022 · 0 comments
Labels
blocked infra-ci

Comments

@michaelsproul
Copy link
Member

Description

There are warnings on CI about Node.js v12 being used in the setup-protoc action. We are waiting on a fix for arduino/setup-protoc#45.
@michaelsproul michaelsproul mentioned this issue Nov 9, 2022
Closed
@michaelsproul michaelsproul added low-hanging-fruit Easy to resolve, get it before someone else does! infra-ci blocked and removed low-hanging-fruit Easy to resolve, get it before someone else does! labels Nov 9, 2022
bors bot pushed a commit that referenced this issue Nov 13, 2022
@michaelsproul
CI gardening maintenance (#3706)
9bd6d9c 
## Issue Addressed

Closes #3656

## Proposed Changes

* Replace `set-output` by `$GITHUB_OUTPUT` usage
* Avoid rate-limits when installing `protoc` by making authenticated requests (continuation of #3621)
* Upgrade all Ubuntu 18.04 usage to 22.04 (18.04 is end of life)
* Upgrade macOS-latest to explicit macOS-12 to silence warning
* Use `actions/checkout@v3` and `actions/cache@v3` to avoid deprecated NodeJS v12

## Additional Info

Can't silence the NodeJS warnings entirely due to #3705. Can fix that in future.
@michaelsproul michaelsproul mentioned this issue Dec 16, 2022
Closed
bors bot pushed a commit that referenced this issue Dec 20, 2022
@michaelsproul
Various CI fixes (#3813)
cb1eb76 
## Issue Addressed

Closes #3812
Closes #3750
Closes #3705
macladson pushed a commit to macladson/lighthouse that referenced this issue Jan 5, 2023
@michaelsproul @macladson
CI gardening maintenance (sigp#3706)
8a28525 
## Issue Addressed

Closes sigp#3656

## Proposed Changes

* Replace `set-output` by `$GITHUB_OUTPUT` usage
* Avoid rate-limits when installing `protoc` by making authenticated requests (continuation of sigp#3621)
* Upgrade all Ubuntu 18.04 usage to 22.04 (18.04 is end of life)
* Upgrade macOS-latest to explicit macOS-12 to silence warning
* Use `actions/checkout@v3` and `actions/cache@v3` to avoid deprecated NodeJS v12

## Additional Info

Can't silence the NodeJS warnings entirely due to sigp#3705. Can fix that in future.
macladson pushed a commit to macladson/lighthouse that referenced this issue Jan 5, 2023
@michaelsproul @macladson
Various CI fixes (sigp#3813)
78bd301 
## Issue Addressed

Closes sigp#3812
Closes sigp#3750
Closes sigp#3705
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@michaelsproul @Woodpile37
CI gardening maintenance (sigp#3706)
2ab3524 
## Issue Addressed

Closes sigp#3656

## Proposed Changes

* Replace `set-output` by `$GITHUB_OUTPUT` usage
* Avoid rate-limits when installing `protoc` by making authenticated requests (continuation of sigp#3621)
* Upgrade all Ubuntu 18.04 usage to 22.04 (18.04 is end of life)
* Upgrade macOS-latest to explicit macOS-12 to silence warning
* Use `actions/checkout@v3` and `actions/cache@v3` to avoid deprecated NodeJS v12

## Additional Info

Can't silence the NodeJS warnings entirely due to sigp#3705. Can fix that in future.
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@michaelsproul @Woodpile37
Various CI fixes (sigp#3813)
8e6ad3a 
## Issue Addressed

Closes sigp#3812
Closes sigp#3750
Closes sigp#3705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked infra-ci
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelsproul