Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Various CI fixes #3813

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - Various CI fixes #3813

wants to merge 13 commits into from

Conversation

michaelsproul
Copy link
Member

Issue Addressed

Closes #3812
Closes #3750
Closes #3705

@michaelsproul michaelsproul added work-in-progress PR is a work-in-progress infra-ci labels Dec 16, 2022
@michaelsproul michaelsproul added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Dec 19, 2022
@divagant-martian
Copy link
Collaborator

Why this specific commit hash for the actions? just curious

@michaelsproul
Copy link
Member Author

Why this specific commit hash for the actions?

The setup-protoc action hasn't tagged any new version since upgrading to Node.js 16, and I'm trying to avoid the deprecation notice for Node.js 12. That commit is just the latest one as of a few days ago. If/when they make a release we could upgrade to it

@divagant-martian divagant-martian added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Dec 19, 2022
@michaelsproul michaelsproul added the work-in-progress PR is a work-in-progress label Dec 19, 2022
@michaelsproul
Copy link
Member Author

Ok yay, after tweaking the GITHUB_TOKEN permissions on my fork I was able to get the release flow to push a draft release: https://github.com/michaelsproul/lighthouse/actions/runs/3736310168.

The only issue was that download-artifact wasn't upgraded, so I've bumped it in this commit: 46ccb13

Lets merge

bors r+

bors bot pushed a commit that referenced this pull request Dec 20, 2022
@michaelsproul
Various CI fixes (#3813)
cb1eb76 
## Issue Addressed

Closes #3812
Closes #3750
Closes #3705
@michaelsproul michaelsproul removed the work-in-progress PR is a work-in-progress label Dec 20, 2022
@michaelsproul
Copy link
Member Author

gonna batch

bors r-

@bors
Copy link

bors bot commented Dec 20, 2022

Canceled.

@michaelsproul
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Dec 20, 2022
@michaelsproul
Various CI fixes (#3813)
59a7a47 
## Issue Addressed

Closes #3812
Closes #3750
Closes #3705
@bors
Copy link

bors bot commented Dec 20, 2022

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Various CI fixes [Merged by Bors] - Various CI fixes Dec 20, 2022
@bors bors bot closed this Dec 20, 2022
@michaelsproul michaelsproul deleted the ci-fixes branch December 20, 2022 04:23
macladson pushed a commit to macladson/lighthouse that referenced this pull request Jan 5, 2023
@michaelsproul @macladson
Various CI fixes (sigp#3813)
78bd301 
## Issue Addressed

Closes sigp#3812
Closes sigp#3750
Closes sigp#3705
@paulhauner paulhauner mentioned this pull request Jan 9, 2023
Closed
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@michaelsproul @Woodpile37
Various CI fixes (sigp#3813)
8e6ad3a 
## Issue Addressed

Closes sigp#3812
Closes sigp#3750
Closes sigp#3705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divagant-martian divagant-martian divagant-martian approved these changes

Assignees
No one assigned
Labels
infra-ci ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsproul @divagant-martian