Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows unrestricted perms on logs differ from Linux #4162

Closed
michaelsproul opened this issue Apr 4, 2023 · 3 comments
Closed

Windows unrestricted perms on logs differ from Linux #4162

michaelsproul opened this issue Apr 4, 2023 · 3 comments
Labels
docs Documentation good first issue Good for newcomers windows

Comments

@michaelsproul
Copy link
Member

michaelsproul commented Apr 4, 2023

Regarding the --logfile-no-restricted-perms flag added in #3747:

@michaelsproul I think the flag help text is a bit misleading. When using this flag on Windows, the log file permissions are inherited from the parent folder (as expected), which does not necessarily mean "world-readable". It depends on the permissions set on the parent folder, which can be totally secure.

Originally posted by @ostracoder in #3747 (comment)

@michaelsproul michaelsproul added good first issue Good for newcomers docs Documentation windows labels Apr 4, 2023
@michaelsproul
Copy link
Member Author

We could either fix this by:

  • Documenting that the behaviour is different on Windows, or
  • Changing the permissions used on Windows so that they're closer to world-readable

I think the former is probably better given the name of the flag

@michaelsproul michaelsproul changed the title Windows world-readable logs differ from Linux Windows unrestricted perms on logs differ from Linux Apr 4, 2023
@eserilev
Copy link
Collaborator

eserilev commented Apr 5, 2023

hi, i'd like to take a stab at this. to document that the flags behavior is different on windows I was planning on updating the flag help text to:

"If present, log files will be generated as world-readable meaning they can be read by any user on the machine. Note that logs can often contain sensitive information about your validator and so this flag should be used with caution. For Windows users, the log file permissions will be inherited from the parent folder."

PR: #4165

bors bot pushed a commit that referenced this issue May 1, 2023
## Issue Addressed

[#4162](#4162)

## Proposed Changes

update `--logfile-no-restricted-perms` flag help text to indicate that, for Windows users, the file permissions are inherited from the parent folder

## Additional Info

N/A
ghost pushed a commit to oone-world/lighthouse that referenced this issue Jul 13, 2023
## Issue Addressed

[sigp#4162](sigp#4162)

## Proposed Changes

update `--logfile-no-restricted-perms` flag help text to indicate that, for Windows users, the file permissions are inherited from the parent folder

## Additional Info

N/A
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
## Issue Addressed

[sigp#4162](sigp#4162)

## Proposed Changes

update `--logfile-no-restricted-perms` flag help text to indicate that, for Windows users, the file permissions are inherited from the parent folder

## Additional Info

N/A
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
## Issue Addressed

[sigp#4162](sigp#4162)

## Proposed Changes

update `--logfile-no-restricted-perms` flag help text to indicate that, for Windows users, the file permissions are inherited from the parent folder

## Additional Info

N/A
@chong-he
Copy link
Member

Close with #4165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation good first issue Good for newcomers windows
Projects
None yet
Development

No branches or pull requests

3 participants