Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Logfile no restrict help text for windows #4165

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Logfile no restrict help text for windows #4165

wants to merge 2 commits into from

Conversation

eserilev
Copy link
Collaborator

@eserilev eserilev commented Apr 5, 2023 •
edited
Loading

Issue Addressed

#4162

Proposed Changes

update --logfile-no-restricted-perms flag help text to indicate that, for Windows users, the file permissions are inherited from the parent folder

Additional Info

N/A

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@eserilev eserilev mentioned this pull request Apr 5, 2023
Closed
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. UX-and-logs labels May 1, 2023
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request May 1, 2023
@eserilev
Logfile no restrict help text for windows (#4165)
11103d6 
## Issue Addressed

[#4162](#4162)

## Proposed Changes

update `--logfile-no-restricted-perms` flag help text to indicate that, for Windows users, the file permissions are inherited from the parent folder

## Additional Info

N/A
@bors
Copy link

bors bot commented May 1, 2023

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Logfile no restrict help text for windows [Merged by Bors] - Logfile no restrict help text for windows May 1, 2023
@bors bors bot closed this May 1, 2023
ghost pushed a commit to oone-world/lighthouse that referenced this pull request Jul 13, 2023
@eserilev
Logfile no restrict help text for windows (sigp#4165)
29ffa82 
## Issue Addressed

[sigp#4162](sigp#4162)

## Proposed Changes

update `--logfile-no-restricted-perms` flag help text to indicate that, for Windows users, the file permissions are inherited from the parent folder

## Additional Info

N/A
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@eserilev @Woodpile37
Logfile no restrict help text for windows (sigp#4165)
d4da7b7 
## Issue Addressed

[sigp#4162](sigp#4162)

## Proposed Changes

update `--logfile-no-restricted-perms` flag help text to indicate that, for Windows users, the file permissions are inherited from the parent folder

## Additional Info

N/A
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@eserilev @Woodpile37
Logfile no restrict help text for windows (sigp#4165)
db42e66 
## Issue Addressed

[sigp#4162](sigp#4162)

## Proposed Changes

update `--logfile-no-restricted-perms` flag help text to indicate that, for Windows users, the file permissions are inherited from the parent folder

## Additional Info

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge. UX-and-logs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eserilev @CLAassistant @michaelsproul