Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement genesis EF tests #452

Closed
michaelsproul opened this issue Jul 24, 2019 · 1 comment · Fixed by #466
Closed

Implement genesis EF tests #452

michaelsproul opened this issue Jul 24, 2019 · 1 comment · Fixed by #466
Labels
test improvement Improve tests

Comments

@michaelsproul
Copy link
Member

Description

v0.8 introduces new EF tests for genesis, described here: https://github.com/ethereum/eth2.0-specs/blob/v0.8.1/specs/test_formats/genesis/README.md

We don't yet have a parser and executor for them.

Steps to resolve

Add a parser and executor for the genesis tests.
@michaelsproul
Copy link
Member Author

@paulhauner I'm thinking we could leave this until after v0.0.1 and the v0.8 merge, if we're short on time

@michaelsproul michaelsproul added the test improvement Improve tests label Jul 24, 2019
@michaelsproul michaelsproul mentioned this issue Jul 26, 2019
Merged
michaelsproul added a commit that referenced this issue Jul 30, 2019
@michaelsproul
Add v0.8 genesis tests
a7b68da 
Closes #452
michaelsproul added a commit that referenced this issue Jul 30, 2019
@michaelsproul
Add v0.8 genesis tests
0c90f76 
Closes #452
@michaelsproul michaelsproul mentioned this issue Jul 30, 2019
Merged
michaelsproul added a commit that referenced this issue Jul 30, 2019
@michaelsproul
Add v0.8 genesis tests (#466)
eb669ab 
Closes #452
@paulhauner paulhauner mentioned this issue Sep 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test improvement Improve tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add v0.8 genesis tests sigp/lighthouse
1 participant
@michaelsproul